Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752494AbbH2M14 (ORCPT ); Sat, 29 Aug 2015 08:27:56 -0400 Received: from fw-tnat.cambridge.arm.com ([217.140.96.140]:56289 "EHLO cam-smtp0.cambridge.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751946AbbH2M1y (ORCPT ); Sat, 29 Aug 2015 08:27:54 -0400 Date: Sat, 29 Aug 2015 13:27:46 +0100 From: Javi Merino To: Linus Torvalds Cc: "edubezval@gmail.com" , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Dmitry Torokhov , Zhang Rui Subject: Re: [PATCH] thermal: power_allocator: allocate with kcalloc what you free with kfree Message-ID: <20150829122737.GA2840@e104805> References: <1440526955-9860-1-git-send-email-javi.merino@arm.com> <20150827154936.GH5653@e104805> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150827154936.GH5653@e104805> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1579 Lines: 38 Hi Linus, On Thu, Aug 27, 2015 at 04:49:37PM +0100, Javi Merino wrote: > On Tue, Aug 25, 2015 at 07:22:35PM +0100, Javi Merino wrote: > > Commit cf736ea6f902 ("thermal: power_allocator: do not use devm* > > interfaces") forgot to change a devm_kcalloc() to just kcalloc(), but > > it's corresponding devm_kfree() was changed to kfree(). Allocate with > > kcalloc() to match the kfree(). > > > > Fixes: cf736ea6f902 ("thermal: power_allocator: do not use devm* interfaces") > > Cc: Dmitry Torokhov > > Cc: Eduardo Valentin > > Cc: Zhang Rui > > Signed-off-by: Javi Merino > > --- > > > > Can this be merged for 4.2, please? I'm having memory problems with > > 4.2-rc8 because of this. > > Please merge this for 4.2 or revert cf736ea6f902 ("thermal: > power_allocator: do not use devm* interfaces") cf736ea6f902 ("thermal: power_allocator: do not use devm* interfaces") was merged for 4.2-rc8. It leaves an allocation of memory with devm_kcalloc() that is then freed with kfree(). The patch at the top of the thread[0][1] fixes this. Can you either merge this patch or revert cf736ea6f902 for 4.2? [0] https://patchwork.kernel.org/patch/7072591/ [1] Message-ID: <1440526955-9860-1-git-send-email-javi.merino@arm.com> Thanks, Javi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/