Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752508AbbH2N5R (ORCPT ); Sat, 29 Aug 2015 09:57:17 -0400 Received: from verein.lst.de ([213.95.11.211]:53105 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752135AbbH2N5Q (ORCPT ); Sat, 29 Aug 2015 09:57:16 -0400 Date: Sat, 29 Aug 2015 15:57:14 +0200 From: "hch@lst.de" To: "Williams, Dan J" Cc: "toshi.kani@hp.com" , "linux-kernel@vger.kernel.org" , "mingo@kernel.org" , "linux-mm@kvack.org" , "tglx@linutronix.de" , "hch@lst.de" , "hpa@zytor.com" , "linux-nvdimm@lists.01.org" , "mingo@redhat.com" , "ross.zwisler@linux.intel.com" , "boaz@plexistor.com" , "david@fromorbit.com" Subject: Re: [PATCH v2 5/9] x86, pmem: push fallback handling to arch code Message-ID: <20150829135714.GC13103@lst.de> References: <20150826010220.8851.18077.stgit@dwillia2-desk3.amr.corp.intel.com> <20150826012751.8851.78564.stgit@dwillia2-desk3.amr.corp.intel.com> <20150826124124.GA7613@lst.de> <1440624859.31365.17.camel@intel.com> <1440798084.14237.106.camel@hp.com> <1440798506.14237.107.camel@hp.com> <1440821097.32027.2.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1440821097.32027.2.camel@intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1274 Lines: 32 On Sat, Aug 29, 2015 at 04:04:58AM +0000, Williams, Dan J wrote: > On Fri, 2015-08-28 at 15:48 -0600, Toshi Kani wrote: > > On Fri, 2015-08-28 at 14:47 -0700, Dan Williams wrote: > > > On Fri, Aug 28, 2015 at 2:41 PM, Toshi Kani wrote: > > > > On Wed, 2015-08-26 at 21:34 +0000, Williams, Dan J wrote: > > > [..] > > > > > -#define ARCH_MEMREMAP_PMEM MEMREMAP_WB > > > > > > > > Should it be better to do: > > > > > > > > #else /* !CONFIG_ARCH_HAS_PMEM_API */ > > > > #define ARCH_MEMREMAP_PMEM MEMREMAP_WT > > > > > > > > so that you can remove all '#ifdef ARCH_MEMREMAP_PMEM' stuff? > > > > > > Yeah, that seems like a nice incremental cleanup for memremap_pmem() > > > to just unconditionally use ARCH_MEMREMAP_PMEM, feel free to send it > > > along. > > > > OK. Will do. > > > > Here's the re-worked patch with Toshi's fixes folded in: I like this in principle, but we'll have to be carefull now if we want to drop the fallbacks in mremap, as we will have to shift it into the pmem driver then. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/