Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752876AbbH2QSa (ORCPT ); Sat, 29 Aug 2015 12:18:30 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:38917 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752418AbbH2QS1 (ORCPT ); Sat, 29 Aug 2015 12:18:27 -0400 X-IronPort-AV: E=Sophos;i="5.17,429,1437429600"; d="scan'208";a="144151548" Date: Sat, 29 Aug 2015 18:18:20 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: "Luis R. Rodriguez" cc: ming.lei@canonical.com, Julia Lawall , torvalds@linux-foundation.org, liam.r.girdwood@linux.intel.com, yang.jie@intel.com, tiwai@suse.de, dmitry.torokhov@gmail.com, joonas.lahtinen@linux.intel.com, teg@jklm.no, viro@zeniv.linux.org.uk, gregkh@linuxfoundation.org, kay@vrfy.org, dwmw2@infradead.org, linux-kernel@vger.kernel.org, yalin.wang2010@gmail.com, "Luis R. Rodriguez" , Jonathan Corbet , Gilles Muller , Nicolas Palix , Michal Marek , linux-doc@vger.kernel.org, cocci@systeme.lip6.fr, Alessandro Rubini , Kevin Cernekee , Jiri Slaby , linux-serial@vger.kernel.org Subject: Re: [RFC] firmware: annotate thou shalt not request fw on init or probe In-Reply-To: <1440811107-861-1-git-send-email-mcgrof@do-not-panic.com> Message-ID: References: <1440811107-861-1-git-send-email-mcgrof@do-not-panic.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1072 Lines: 31 > +@ defines_module_init exists @ > +declarer name module_init; > +identifier init; > +@@ > + > +module_init(init); > + > +@ has_probe depends on defines_module_init @ > +identifier drv_calls, drv_probe; > +type bus_driver; > +identifier probe_op =~ "(probe)"; > +@@ > + > +bus_driver drv_calls = { > + .probe_op = drv_probe, > +}; I'm not sure that this is enough. For example, there is the macro platform_driver_probe that initializes probe fields. There is likewise module_platform_driver, which is a top-level declaration that encapsulates the module_init and the definition of the module_init function, which in turn calls platform_driver_probe. There is also module_platform_driver, which encapsulates the module_init, but not the initialization of the probe field. Are you concerned with any of these cases? julia -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/