Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752467AbbH3VUq (ORCPT ); Sun, 30 Aug 2015 17:20:46 -0400 Received: from ozlabs.org ([103.22.144.67]:43309 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752307AbbH3VUp (ORCPT ); Sun, 30 Aug 2015 17:20:45 -0400 X-powerpc-patch-notification: thanks X-powerpc-patch-commit: af2a50bb0ce1ca7a9c4784813419c922bf2285df In-Reply-To: <1440669019-23800-1-git-send-email-imunsie@au.ibm.com> To: Ian Munsie From: Michael Ellerman Cc: Matt Ochs , linuxppc-dev , mikey , linux-kernel , Ian Munsie Subject: Re: [1/2] cxl: Fix + cleanup error paths in cxl_dev_context_init Message-Id: <20150830212043.80FFA14016A@ozlabs.org> Date: Mon, 31 Aug 2015 07:20:43 +1000 (AEST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 866 Lines: 23 On Thu, 2015-27-08 at 09:50:18 UTC, Ian Munsie wrote: > From: Ian Munsie > > If the cxl_context_alloc() call fails, we return immediately without > releasing the reference on the AFU device, allowing it to leak. > > This patch switches to using goto style error handling so that the > device is released in common code for both error paths, and will also > simplify things if we add additional initialisation in this function in > the future. > > Signed-off-by: Ian Munsie Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/af2a50bb0ce1ca7a9c478481 cheers -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/