Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752369AbbHaCk4 (ORCPT ); Sun, 30 Aug 2015 22:40:56 -0400 Received: from regular1.263xmail.com ([211.150.99.139]:41079 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752292AbbHaCky (ORCPT ); Sun, 30 Aug 2015 22:40:54 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 191.101.57.10 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: <4862dd0f266f3eb43ea669553d59135f> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <55E3BEA6.50407@rock-chips.com> Date: Mon, 31 Aug 2015 10:40:38 +0800 From: Yakir Yang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Romain Perier , Thierry Reding CC: Jingoo Han , Heiko Stuebner , Fabio Estevam , Inki Dae , "joe@perches.com" , Russell King , "djkurtz@google.com" , "dianders@google.com" , "seanpaul@google.com" , Takashi Iwai , "ajaynumb@gmail.com" , Andrzej Hajda , Kyungmin Park , Philipp Zabel , David Airlie , Gustavo Padovan , Vincent Palatin , Mark Yao , Andy Yan , Kumar Gala , Ian Campbell , Rob Herring , Pawel Moll , Kishon Vijay Abraham I , "dri-devel@lists.freedesktop.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" , "linux-rockchip@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v3 0/14] Add Analogix Core Display Port Driver References: <1439995728-18046-1-git-send-email-ykk@rock-chips.com> <105A0032-83A0-4B75-AE94-258F12451670@gmail.com> <55D6F6F8.70504@rock-chips.com> <8384E112-E1F4-4CD3-85BF-A2A25989783F@gmail.com> <20150821131631.GC22118@ulmo.nvidia.com> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3480 Lines: 92 Hi Romain, 在 08/30/2015 08:16 PM, Romain Perier 写道: > Hi, > > Could you rebase your serie onto linux-next or 4.2-rc8 ? it does not > apply here... Thanks for try to applied, and feel sorry for that failed. This v3 series was rebased on github.com/torvalds/linux.git, so I should rebase on kernel/next/linux-next.git when I'm preparing v4 series. Thanks, - Yakir > Regards, > Romain > > 2015-08-21 15:16 GMT+02:00 Thierry Reding : >> On Fri, Aug 21, 2015 at 08:24:16PM +0900, Jingoo Han wrote: >>> On 2015. 8. 21., at PM 7:01, Yakir Yang wrote: >>>> Hi Jingoo, >>>> >>>>> 在 2015/8/21 16:20, Jingoo Han 写道: >>>>>> On 2015. 8. 19., at PM 11:48, Yakir Yang wrote: >>>>> ..... >>>>> >>>>>> .../bindings/video/analogix_dp-rockchip.txt | 83 ++ >>>>>> .../devicetree/bindings/video/exynos_dp.txt | 51 +- >>>>>> arch/arm/boot/dts/exynos5250-arndale.dts | 10 +- >>>>>> arch/arm/boot/dts/exynos5250-smdk5250.dts | 10 +- >>>>>> arch/arm/boot/dts/exynos5250-snow.dts | 12 +- >>>>>> arch/arm/boot/dts/exynos5250-spring.dts | 12 +- >>>>>> arch/arm/boot/dts/exynos5420-peach-pit.dts | 12 +- >>>>>> arch/arm/boot/dts/exynos5420-smdk5420.dts | 10 +- >>>>>> arch/arm/boot/dts/exynos5800-peach-pi.dts | 12 +- >>>>>> drivers/gpu/drm/bridge/Kconfig | 5 + >>>>>> drivers/gpu/drm/bridge/Makefile | 1 + >>>>>> drivers/gpu/drm/bridge/analogix_dp_core.c | 1382 +++++++++++++++++++ >>>>>> drivers/gpu/drm/bridge/analogix_dp_core.h | 286 ++++ >>>>>> drivers/gpu/drm/bridge/analogix_dp_reg.c | 1294 ++++++++++++++++++ >>>>>> .../exynos_dp_reg.h => bridge/analogix_dp_reg.h} | 270 ++-- >>>>>> drivers/gpu/drm/exynos/Kconfig | 5 +- >>>>>> drivers/gpu/drm/exynos/Makefile | 2 +- >>>>>> drivers/gpu/drm/exynos/analogix_dp-exynos.c | 347 +++++ >>>>> Would you change this file name to "exynos_dp.c"? >>>> Sorry, I don't think so ;( >>>> >>>> I think IP_name+Soc_name would be better in this re-use case. >>> So? Is there the naming rule such as "IP_name+SoC_name"? >>> >>>> Beside I see >>>> there are lots of driver named with this format in kernel, such as dw_hdmi & dw_mmc >>> Please look at other dw cases. >>> For example, look at dw_pcie. >>> >>> drivers/pci/host/ >>> pcie-designware.c >>> pci-spear13xx.c >>> pci-exynos.c >>> >>> In this case, pci-spear13xx.c and pci-exynos.c do not use "IP_name+SoC_name", even though these are dw IPs. >>> >>> Also, naming consistency is more important. >>> Now, Exynos DRM files are using "exynos_drm_" prefix. >>> >>> drivers/gpu/drm/exynos/ >>> exynos_drm_buf.c >>> exynos_drm_core.c >>> .... >>> >>> However, "analogix_dp-exynos.c" looks very inconsistent. >>> >>> If there is no strict naming rule, please use "exynos_dp.c" >>> or "exynos_drm_dp.c". >> Exynos DRM maintainers get to pick their filenames, so Yakir, please >> rename as Jingoo suggested. >> >> Even if you didn't the first thing that would go into the Exynos DRM >> driver tree after this is merged is a rename patch anyway. >> >> Thierry > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/