Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751943AbbHaFRQ (ORCPT ); Mon, 31 Aug 2015 01:17:16 -0400 Received: from mail-oi0-f42.google.com ([209.85.218.42]:35797 "EHLO mail-oi0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750812AbbHaFRO (ORCPT ); Mon, 31 Aug 2015 01:17:14 -0400 MIME-Version: 1.0 In-Reply-To: <55DC2997.9030705@ti.com> References: <1440417930-15876-1-git-send-email-van.freenix@gmail.com> <55DC2997.9030705@ti.com> From: Alexandre Courbot Date: Mon, 31 Aug 2015 14:16:54 +0900 Message-ID: Subject: Re: [PATCH] gpio: gpiolib: use devm_* API to simplify driver code To: Grygorii Strashko Cc: Peng Fan , Linus Walleij , "linux-gpio@vger.kernel.org" , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1405 Lines: 38 On Tue, Aug 25, 2015 at 5:38 PM, Grygorii Strashko wrote: > On 08/24/2015 03:05 PM, Peng Fan wrote: >> >> Use devm_* API to simplify driver code. >> >> Signed-off-by: Peng Fan >> Cc: Linus Walleij >> Cc: Alexandre Courbot > > --- >> >> drivers/gpio/gpiolib.c | 11 +++++------ >> 1 file changed, 5 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c >> index 6bc612b..f9470b0 100644 >> --- a/drivers/gpio/gpiolib.c >> +++ b/drivers/gpio/gpiolib.c >> @@ -243,7 +243,8 @@ int gpiochip_add(struct gpio_chip *chip) >> int base = chip->base; >> struct gpio_desc *descs; >> >> - descs = kcalloc(chip->ngpio, sizeof(descs[0]), GFP_KERNEL); >> + descs = devm_kcalloc(chip->dev, chip->ngpio, sizeof(descs[0]), >> + GFP_KERNEL); > > > ^ above will not work for every one as NOT all GPIO drivers > implemented using dev/drv model, so chip->dev could be not set > (at least it was true when I've checked it last time). AFAICT that is still true as of today. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/