Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752868AbbHaLTY (ORCPT ); Mon, 31 Aug 2015 07:19:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58918 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751631AbbHaLTR (ORCPT ); Mon, 31 Aug 2015 07:19:17 -0400 Date: Mon, 31 Aug 2015 13:19:12 +0200 From: Jiri Olsa To: Kan Liang Cc: acme@kernel.org, jolsa@kernel.org, a.p.zijlstra@chello.nl, luto@kernel.org, mingo@redhat.com, eranian@google.com, ak@linux.intel.com, mark.rutland@arm.com, adrian.hunter@intel.com, namhyung@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V7 6/8] perf,tools: Dump per-sample freq/CPU%/CORE_BUSY% in report -D Message-ID: <20150831111912.GH22039@krava.brq.redhat.com> References: <1440755289-30939-1-git-send-email-kan.liang@intel.com> <1440755289-30939-7-git-send-email-kan.liang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1440755289-30939-7-git-send-email-kan.liang@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1074 Lines: 30 On Fri, Aug 28, 2015 at 05:48:07AM -0400, Kan Liang wrote: > From: Kan Liang > > The group read results from cycles/ref-cycles/TSC/ASTATE/MSTATE event > can be used to calculate the frequency, CPU Utilization and percent > performance during each sampling period. > This patch shows them in report -D. > > Here is an example: > > $ perf record -e > '{cycles,ref-cycles,msr/tsc/,msr/mperf/,msr/aperf/}:S' ~/tchain_edit so this perf cord set of events is set when you want to get the freq data/ratios.. I think we should not force user to specify this on command line and provide short option for that like $ perf record --freq ~/tchain_edit we already do this in perf stat for transactions.. you can also check the existence of particular events and warn user appropriatelly if any is missing jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/