Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752918AbbHaLtH (ORCPT <rfc822;w@1wt.eu>);
	Mon, 31 Aug 2015 07:49:07 -0400
Received: from mail-wi0-f175.google.com ([209.85.212.175]:34504 "EHLO
	mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752374AbbHaLtF (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 31 Aug 2015 07:49:05 -0400
MIME-Version: 1.0
In-Reply-To: <55DF8B37.4060508@osg.samsung.com>
References: <1439881319-9727-1-git-send-email-naresh.kamboju@linaro.org>
	<55DF5288.4040405@osg.samsung.com>
	<55DF8B37.4060508@osg.samsung.com>
Date: Mon, 31 Aug 2015 17:19:03 +0530
Message-ID: <CA+G9fYuiaPpZYKkCggUbVWwJoTOysoCbYH0cx8Gqno0FTWhoOQ@mail.gmail.com>
Subject: Re: [PATCH v3] selftests/zram: Adding zram tests
From: Naresh Kamboju <naresh.kamboju@linaro.org>
To: Shuah Khan <shuahkh@osg.samsung.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Tyler Baker <tyler.baker@linaro.org>,
        Milosz Wasilewski <milosz.wasilewski@linaro.org>,
        alexey.kodanev@oracle.com
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2128
Lines: 65

On 28 August 2015 at 03:42, Shuah Khan <shuahkh@osg.samsung.com> wrote:
> On 08/27/2015 12:10 PM, Shuah Khan wrote:
>> On 08/18/2015 01:01 AM, naresh.kamboju@linaro.org wrote:
>>> From: Naresh Kamboju <naresh.kamboju@linaro.org>
>>>
>>> zram: Compressed RAM based block devices
>>> ----------------------------------------
>>> The zram module creates RAM based block devices named /dev/zram<id>
>>> (<id> = 0, 1, ...). Pages written to these disks are compressed and stored
>>> in memory itself. These disks allow very fast I/O and compression provides
>>> good amounts of memory savings. Some of the usecases include /tmp storage,
>>> use as swap disks, various caches under /var and maybe many more :)
>>>
>>> Statistics for individual zram devices are exported through sysfs nodes at
>>> /sys/block/zram<id>/
>>>
>>> This patch is to validate the zram functionality. Test interacts with block
>>> device /dev/zram<id> and sysfs nodes /sys/block/zram<id>/
>>>
>>
>> Hi Naresh,
>>
>> This doesn't fail gracefully when a regular user runs it. Please add
>> a check for root and make the test fail gracefully when a non-root
>> user runs it.
>>
>> Please refer to tools/testing/selftests/efivarfs/efivarfs.sh
>> for an example on how to check for root.
>>
>> I was getting ready to apply this to linux-kselftest next for 4.3
>> and ran some sanity tests. If you get me new revision quickly
>> I can get it into 4.3-rc1.
>
> Hi Naresh,


Shuah,

>
> The patch is now in linux-kselftest next. Please send a fix in for
> the non-root case for me get it into 4.3-rc1 or rc2.

Well, non-root user check needed here.

selftests/zram:  must be run as root - patch sent for review.


Thank you
Naresh

>
> thanks,
> -- Shuah
>
> --
> Shuah Khan
> Sr. Linux Kernel Developer
> Open Source Innovation Group
> Samsung Research America (Silicon Valley)
> shuahkh@osg.samsung.com | (970) 217-8978
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/