Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752853AbbHaMNL (ORCPT ); Mon, 31 Aug 2015 08:13:11 -0400 Received: from relay.parallels.com ([195.214.232.42]:40661 "EHLO relay.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752276AbbHaMNJ (ORCPT ); Mon, 31 Aug 2015 08:13:09 -0400 Message-ID: <55E444C8.3020402@odin.com> Date: Mon, 31 Aug 2015 15:12:56 +0300 From: Kirill Tkhai User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Peter Zijlstra CC: , Tejun Heo , Li Zefan Subject: Re: [PATCH] cgroup, cleanup: Delete PF_EXITING checks from cgroup_exit() callbacks References: <55E43F67.6070407@odin.com> <20150831115315.GF16853@twins.programming.kicks-ass.net> In-Reply-To: <20150831115315.GF16853@twins.programming.kicks-ass.net> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: US-EXCH.sw.swsoft.com (10.255.249.47) To MSK-EXCH1.sw.swsoft.com (10.67.48.55) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2214 Lines: 66 On 31.08.2015 14:53, Peter Zijlstra wrote: > On Mon, Aug 31, 2015 at 02:49:59PM +0300, Kirill Tkhai wrote: >> Remove useless checks and outdates commentaries. > > A slightly bigger Changelog could do, maybe also referring to the commit > that made these checks obsolete. > [PATCH] cgroup, cleanup: Delete PF_EXITING checks from cgroup_exit() callbacks cgroup_exit() is not called from copy_process() after commit e8604cb43690b781: "cgroup: fix spurious lockdep warning in cgroup_exit()", it's only called from do_exit(). So these checks are useless and commentaries are obsolete. Remove them. Signed-off-by: Kirill Tkhai --- kernel/events/core.c | 8 -------- kernel/sched/core.c | 8 -------- 2 files changed, 16 deletions(-) diff --git a/kernel/events/core.c b/kernel/events/core.c index ae16867..94bd500 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -9219,14 +9219,6 @@ static void perf_cgroup_exit(struct cgroup_subsys_state *css, struct cgroup_subsys_state *old_css, struct task_struct *task) { - /* - * cgroup_exit() is called in the copy_process() failure path. - * Ignore this case since the task hasn't ran yet, this avoids - * trying to poke a half freed task state from generic code. - */ - if (!(task->flags & PF_EXITING)) - return; - task_function_call(task, __perf_cgroup_move, task); } diff --git a/kernel/sched/core.c b/kernel/sched/core.c index b3386c6..f8509be 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -8167,14 +8167,6 @@ static void cpu_cgroup_exit(struct cgroup_subsys_state *css, struct cgroup_subsys_state *old_css, struct task_struct *task) { - /* - * cgroup_exit() is called in the copy_process() failure path. - * Ignore this case since the task hasn't ran yet, this avoids - * trying to poke a half freed task state from generic code. - */ - if (!(task->flags & PF_EXITING)) - return; - sched_move_task(task); } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/