Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753052AbbHaMTy (ORCPT ); Mon, 31 Aug 2015 08:19:54 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:35828 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752606AbbHaMTx (ORCPT ); Mon, 31 Aug 2015 08:19:53 -0400 MIME-Version: 1.0 In-Reply-To: <1440994070.5735.5.camel@ellerman.id.au> References: <1439881319-9727-1-git-send-email-naresh.kamboju@linaro.org> <1440994070.5735.5.camel@ellerman.id.au> Date: Mon, 31 Aug 2015 17:49:51 +0530 Message-ID: Subject: Re: [PATCH v3] selftests/zram: Adding zram tests From: Naresh Kamboju To: Michael Ellerman Cc: "linux-kernel@vger.kernel.org" , Tyler Baker , Milosz Wasilewski , Shuah Khan , alexey.kodanev@oracle.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1448 Lines: 59 On 31 August 2015 at 09:37, Michael Ellerman wrote: > On Tue, 2015-08-18 at 12:31 +0530, naresh.kamboju@linaro.org wrote: >> From: Naresh Kamboju >> >> diff --git a/tools/testing/selftests/zram/Makefile b/tools/testing/selftests/zram/Makefile >> new file mode 100644 >> index 0000000..ec45513 >> --- /dev/null >> +++ b/tools/testing/selftests/zram/Makefile >> @@ -0,0 +1,12 @@ >> +all: >> + >> +TEST_PROGS := zram.sh >> +TEST_FILES := zram01.sh zram02.sh zram_lib.sh >> + >> +include ../lib.mk >> + >> +run_tests: >> + @/bin/bash ./zram.sh >> + > Michael, > This is wrong, it gives me: > > $ make TARGETS=zram install > ... > Makefile:9: warning: overriding recipe for target 'run_tests' > ../lib.mk:12: warning: ignoring old recipe for target 'run_tests' > > > If you want to define run_tests you need to do: > > override define RUN_TESTS > ./zram.sh > endef > > > BUT, I don't see any reason why you need to override run_tests. The default > rule will just run TEST_PROGS, which is zram.sh so that should work fine? Fixed according to your comments. selftests/zram: Makefile fix - Patch sent for review. Cheers Naresh > > cheers > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/