Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752931AbbHaMrU (ORCPT ); Mon, 31 Aug 2015 08:47:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52669 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752514AbbHaMrT (ORCPT ); Mon, 31 Aug 2015 08:47:19 -0400 Date: Mon, 31 Aug 2015 14:44:42 +0200 From: Oleg Nesterov To: Linus Torvalds Cc: Eric Dumazet , Al Viro , "linux-kernel@vger.kernel.org" , Andrew Morton , Thomas Gleixner , Ingo Molnar , Maciej =?utf-8?Q?=C5=BBenczykowski?= Subject: Re: [PATCH] task_work: remove fifo ordering guarantee Message-ID: <20150831124442.GB31015@redhat.com> References: <1440816150.8932.123.camel@edumazet-glaptop2.roam.corp.google.com> <20150829124921.GA14973@redhat.com> <1440856650.8932.144.camel@edumazet-glaptop2.roam.corp.google.com> <1440857473.8932.146.camel@edumazet-glaptop2.roam.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1148 Lines: 30 On 08/29, Linus Torvalds wrote: > > On Sat, Aug 29, 2015 at 7:11 AM, Eric Dumazet wrote: > > > > If this needs to be kept, maybe then add following, to make sure > > we flush the list at most every BITS_PER_LONG files > > Hmm. > > I'm wondering if we should just make close_files() (or maybe even > filp_close()) use a synchronous fput(). Heh. I thought about the same change. So perhaps it is even the right thing to do. Still I am worried, because "it can't be that simple" ;) And, with this change close_files() is called before exit_fs() and exit_task_namespaces(). This is fine (iiuc), but this means that the creative code in drivers/ can (wrongly) rely on this fact again. IIRC, the change which moved __fput() into task_work_exit() uncovered some interesting problems, like filp_open() called from fop->release(). Anyway, this is the question to Al, I guess. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/