Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753039AbbHaNYT (ORCPT ); Mon, 31 Aug 2015 09:24:19 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:32848 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751373AbbHaNYR (ORCPT ); Mon, 31 Aug 2015 09:24:17 -0400 Date: Mon, 31 Aug 2015 15:24:15 +0200 From: Michal Hocko To: Vladimir Davydov Cc: Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Tejun Heo , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] Fix memcg/memory.high in case kmem accounting is enabled Message-ID: <20150831132414.GG29723@dhcp22.suse.cz> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1677 Lines: 44 On Sun 30-08-15 22:02:16, Vladimir Davydov wrote: > Hi, > > Tejun reported that sometimes memcg/memory.high threshold seems to be > silently ignored if kmem accounting is enabled: > > http://www.spinics.net/lists/linux-mm/msg93613.html > > It turned out that both SLAB and SLUB try to allocate without __GFP_WAIT > first. As a result, if there is enough free pages, memcg reclaim will > not get invoked on kmem allocations, which will lead to uncontrollable > growth of memory usage no matter what memory.high is set to. Right but isn't that what the caller explicitly asked for? Why should we ignore that for kmem accounting? It seems like a fix at a wrong layer to me. Either we should start failing GFP_NOWAIT charges when we are above high wmark or deploy an additional catchup mechanism as suggested by Tejun. I like the later more because it allows to better handle GFP_NOFS requests as well and there are many sources of these from kmem paths. > This patch set attempts to fix this issue. For more details please see > comments to individual patches. > > Thanks, > > Vladimir Davydov (2): > mm/slab: skip memcg reclaim only if in atomic context > mm/slub: do not bypass memcg reclaim for high-order page allocation > > mm/slab.c | 32 +++++++++++--------------------- > mm/slub.c | 24 +++++++++++------------- > 2 files changed, 22 insertions(+), 34 deletions(-) > > -- > 2.1.4 -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/