Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752834AbbHaNhJ (ORCPT ); Mon, 31 Aug 2015 09:37:09 -0400 Received: from casper.infradead.org ([85.118.1.10]:40956 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751373AbbHaNhI (ORCPT ); Mon, 31 Aug 2015 09:37:08 -0400 Date: Mon, 31 Aug 2015 15:37:03 +0200 From: Peter Zijlstra To: Kirill Tkhai Cc: linux-kernel@vger.kernel.org, Tejun Heo , Li Zefan Subject: Re: [PATCH] cgroup, cleanup: Delete PF_EXITING checks from cgroup_exit() callbacks Message-ID: <20150831133703.GL19282@twins.programming.kicks-ass.net> References: <55E43F67.6070407@odin.com> <20150831115315.GF16853@twins.programming.kicks-ass.net> <55E444C8.3020402@odin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55E444C8.3020402@odin.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1391 Lines: 43 I made that two patches, like: --- Subject: perf: Delete PF_EXITING checks from perf_cgroup_exit() callback From: Kirill Tkhai Date: Mon, 31 Aug 2015 15:12:56 +0300 cgroup_exit() is not called from copy_process() after commit: e8604cb43690 ("cgroup: fix spurious lockdep warning in cgroup_exit()") from do_exit(). So this check is useless and the comment is obsolete. Signed-off-by: Kirill Tkhai Signed-off-by: Peter Zijlstra (Intel) Link: http://lkml.kernel.org/r/55E444C8.3020402@odin.com --- kernel/events/core.c | 8 -------- 1 file changed, 8 deletions(-) --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -9219,14 +9219,6 @@ static void perf_cgroup_exit(struct cgro struct cgroup_subsys_state *old_css, struct task_struct *task) { - /* - * cgroup_exit() is called in the copy_process() failure path. - * Ignore this case since the task hasn't ran yet, this avoids - * trying to poke a half freed task state from generic code. - */ - if (!(task->flags & PF_EXITING)) - return; - task_function_call(task, __perf_cgroup_move, task); } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/