Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752967AbbHaNiP (ORCPT ); Mon, 31 Aug 2015 09:38:15 -0400 Received: from casper.infradead.org ([85.118.1.10]:40972 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750829AbbHaNiO (ORCPT ); Mon, 31 Aug 2015 09:38:14 -0400 Date: Mon, 31 Aug 2015 15:38:09 +0200 From: Peter Zijlstra To: Guenter Roeck Cc: Borislav Petkov , Ingo Molnar , Huang Rui , Borislav Petkov , Jean Delvare , Andy Lutomirski , Andreas Herrmann , Thomas Gleixner , "Rafael J. Wysocki" , Len Brown , John Stultz , =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker , lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org, x86@kernel.org, Andreas Herrmann , Aravind Gopalakrishnan , Fengguang Wu , Aaron Lu , Tony Li Subject: Re: [PATCH 09/15] x86, amd: add accessor for number of cores per compute unit Message-ID: <20150831133809.GM19282@twins.programming.kicks-ass.net> References: <1440662866-28716-1-git-send-email-ray.huang@amd.com> <1440662866-28716-10-git-send-email-ray.huang@amd.com> <20150828064814.GB20153@nazgul.tnic> <20150828080418.GB13309@gmail.com> <20150829091914.GA8878@gmail.com> <20150830155322.GA26370@nazgul.tnic> <20150831083821.GE16853@twins.programming.kicks-ass.net> <55E455E8.1060208@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55E455E8.1060208@roeck-us.net> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1282 Lines: 29 On Mon, Aug 31, 2015 at 06:26:00AM -0700, Guenter Roeck wrote: > On 08/31/2015 01:38 AM, Peter Zijlstra wrote: > >On Sun, Aug 30, 2015 at 05:53:22PM +0200, Borislav Petkov wrote: > >>On Sat, Aug 29, 2015 at 11:19:14AM +0200, Ingo Molnar wrote: > >>>So let me withdraw my ack: the much more important question that I > >>>missed first time around, why is this reporting feature living in > >>>hwmon, not in perf? We have energy reporting facilities in perf that > >>>this should be synced to. > >> > >>Because there's already fam15h_power driver which is exactly for that. > >>Making it part of perf is then a question of cat-ting the same sysfs > >>file twice, at the beginning and at the end of the trace, which is > >>trivial. > > > >That don't make sense. > > > >Looking at the BKDG Fam 15h 60h-6Fh these MSRs are per compute unit. > >This means you can do much finer grained measurements than system wide > >-- which is all hwmon seems capable of. > > > > Is it ? Why ? Dunno, because there's that big old loop iterating all cpus? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/