Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753078AbbHaNwH (ORCPT ); Mon, 31 Aug 2015 09:52:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56631 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752085AbbHaNwF (ORCPT ); Mon, 31 Aug 2015 09:52:05 -0400 Date: Mon, 31 Aug 2015 09:52:02 -0400 From: Peter Jones To: Matt Fleming Cc: Paul Gortmaker , linux-kernel@vger.kernel.org, Matt Fleming , linux-efi@vger.kernel.org Subject: Re: [PATCH] drivers/firmware: make efi/esrt.c driver explicitly non-modular Message-ID: <20150831135201.GA17921@redhat.com> References: <1440543648-27328-1-git-send-email-paul.gortmaker@windriver.com> <20150826171128.GA2837@codeblueprint.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150826171128.GA2837@codeblueprint.co.uk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1390 Lines: 36 On Wed, Aug 26, 2015 at 06:11:28PM +0100, Matt Fleming wrote: > On Tue, 25 Aug, at 07:00:48PM, Paul Gortmaker wrote: > > The Kconfig for this driver is currently hidden with: > > > > config EFI_ESRT > > bool > > > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > > when reading the driver there is no doubt it is builtin-only. > > > > Since module_init translates to device_initcall in the non-modular > > case, the init ordering remains unchanged with this commit. > > > > We leave some tags like MODULE_AUTHOR for documentation purposes. > > > > We don't replace module.h with init.h since the file already has that. > > > > Cc: Matt Fleming > > Cc: Peter Jones > > Cc: linux-efi@vger.kernel.org > > Signed-off-by: Paul Gortmaker > > Looks good to me. I know Peter is on vacation right now, so I'm still > expecting a response from him. In the meantime, I'll queue this up in > the EFI 'next' branch. Thanks! Looks fine to me as well. -- Peter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/