Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753458AbbHaPUP (ORCPT ); Mon, 31 Aug 2015 11:20:15 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:37984 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752618AbbHaPUN (ORCPT ); Mon, 31 Aug 2015 11:20:13 -0400 Subject: Re: [PATCH v4] iio: adc: vf610: Add IIO buffer support for Vybrid ADC To: Duan Andy , Sanchayan Maity , "linux-iio@vger.kernel.org" References: <9be567ec7d6f6370dd42a41438d64cf7aaa47635.1439826018.git.maitysanchayan@gmail.com> Cc: "stefan@agner.ch" , "pmeerw@pmeerw.net" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" From: Jonathan Cameron Message-ID: <55E470A8.4000200@kernel.org> Date: Mon, 31 Aug 2015 16:20:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2319 Lines: 57 On 20/08/15 07:50, Duan Andy wrote: > From: Sanchayan Maity Sent: Monday, August 17, 2015 11:52 PM >> To: jic23@kernel.org; linux-iio@vger.kernel.org >> Cc: stefan@agner.ch; Duan Fugang-B38611; pmeerw@pmeerw.net; linux- >> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Sanchayan >> Maity >> Subject: [PATCH v4] iio: adc: vf610: Add IIO buffer support for Vybrid >> ADC >> >> This patch adds support for IIO buffer to the Vybrid ADC driver. >> IIO triggered buffer infrastructure along with iio sysfs trigger is used >> to leverage continuous sampling support provided by the ADC block. >> >> Signed-off-by: Sanchayan Maity >> --- >> >> Changes since v3: >> Fix iio_buffer_setup_ops for postenable and predisable functions to match >> pairwise. Before this the predisable work was being done in postdisable. >> >> Changes since v2: >> 1. Fix the wrong buffer size for statically allocated buffer 2. Drop the >> use of .address field from the iio_chan_spec 3. Use iio_buffer_enabled >> call inside the lock 4. Drop wrapper function around iio_trigered_* >> function calls 5. Drop Kconfig select of sysfs trigger 6. Drop Kconfig >> select IIO_TRIGGER as it is already selected by IIO_TRIGGERED_BUFFER >> >> Changes since v1: >> 1. Use a fixed size buffer instead of kmalloc allocated during update >> scan mode 2. Remove a write to read only register ADC_HS (COCO bit) >> >> drivers/iio/adc/Kconfig | 2 + >> drivers/iio/adc/vf610_adc.c | 105 >> +++++++++++++++++++++++++++++++++++++++++--- >> 2 files changed, 100 insertions(+), 7 deletions(-) >> > > The version is fine for me. Thanks for your effort. > > Acked-by: Fugang Duan Applied to the togreg branch of iio.git - will be initially pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/