Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753692AbbHaPXI (ORCPT ); Mon, 31 Aug 2015 11:23:08 -0400 Received: from fieldses.org ([173.255.197.46]:47766 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752858AbbHaPXF (ORCPT ); Mon, 31 Aug 2015 11:23:05 -0400 Date: Mon, 31 Aug 2015 11:23:04 -0400 From: "J. Bruce Fields" To: Andreas =?utf-8?Q?Gr=C3=BCnbacher?= Cc: Linux Kernel Mailing List , Linux FS-devel Mailing List , Linux NFS Mailing List , Linux API Mailing List , linux-cifs@vger.kernel.org, LSM List , Andreas Gruenbacher Subject: Re: [RFC v6 10/40] richacl: Permission check algorithm Message-ID: <20150831152304.GE17812@fieldses.org> References: <1438689218-6921-1-git-send-email-agruenba@redhat.com> <1438689218-6921-11-git-send-email-agruenba@redhat.com> <20150828214917.GC23326@fieldses.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1191 Lines: 32 On Sat, Aug 29, 2015 at 12:06:22AM +0200, Andreas Grünbacher wrote: > 2015-08-28 23:49 GMT+02:00 J. Bruce Fields : > > On Tue, Aug 04, 2015 at 01:53:08PM +0200, Andreas Gruenbacher wrote: > >> + /* > >> + * We don't care which class the process is in when the acl is > >> + * not masked. > >> + */ > >> + in_owner_or_group_class = 1; > > > > So why bother setting it at all, then? Oh, I see, it lets you break out > > of the loop below earlier. OK. > > Comment changed to: > > /* > * When the acl is not masked, there is no need to determine if > * the process is in the group class and we can earlier break > * out of the loop below. > */ makes sense, just replace "earlier break out" by "break out earlier". > > > Patch makes sense to me, ACK. > > Thanks, > Andreas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/