Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753942AbbHaRFh (ORCPT ); Mon, 31 Aug 2015 13:05:37 -0400 Received: from mga09.intel.com ([134.134.136.24]:51788 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753481AbbHaRFg (ORCPT ); Mon, 31 Aug 2015 13:05:36 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,442,1437462000"; d="scan'208";a="552335528" Date: Mon, 31 Aug 2015 10:05:35 -0700 From: Andi Kleen To: Stephane Eranian Cc: linux-kernel@vger.kernel.org, acme@redhat.com, peterz@infradead.org, mingo@elte.hu, jolsa@redhat.com, namhyung@kernel.org, kan.liang@intel.com, dsahern@gmail.com, adrian.hunter@intel.com Subject: Re: [PATCH v2 4/4] perf script: enable printing of branch stack Message-ID: <20150831170535.GY4524@tassilo.jf.intel.com> References: <1441039273-16260-1-git-send-email-eranian@google.com> <1441039273-16260-5-git-send-email-eranian@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441039273-16260-5-git-send-email-eranian@google.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1313 Lines: 32 > $ perf script -F ip,brstack > 5d3000 0x401aa0/0x5d2000/M/-/-/-/0 ... > > $ perf script -F ip,brstacksym > 4011e0 noploop+0x0/noploop+0x0/P/-/-/0 That's a weird format that's hard to parse with standard tools like awk, and also for humans. How about separating with spaces? > @@ -175,6 +175,16 @@ OPTIONS > Finally, a user may not set fields to none for all event types. > i.e., -f "" is not allowed. > > + The brstack output includes branch related information with raw addresses using the > + /v/v/v/v/ syntax in the following order: > + FROM: branch source instruction > + TO : branch target instruction > + M/P/-: M=branch target mispredicted or branch direction was mispredicted, P=target predicted or direction predicted, -=not supported > + X/- : X=branch inside a transactional region, -=not in transaction region or not supported > + A/- : A=TSX abort entry, -=not aborted region or not supported Need to describe cycles here too. The rest looks good to me. Should probably add brstacksrcline too, but that can be done later. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/