Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754323AbbHaTn1 (ORCPT ); Mon, 31 Aug 2015 15:43:27 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:48029 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751571AbbHaTnZ (ORCPT ); Mon, 31 Aug 2015 15:43:25 -0400 Message-ID: <55E4AE5A.7010003@roeck-us.net> Date: Mon, 31 Aug 2015 12:43:22 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: David Miller , ast@plumgrid.com CC: fengguang.wu@intel.com, rostedt@goodmis.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] lib: move strncpy_from_unsafe() into mm/maccess.c References: <1441036630-10124-1-git-send-email-ast@plumgrid.com> <20150831.123628.1591879942458458246.davem@davemloft.net> In-Reply-To: <20150831.123628.1591879942458458246.davem@davemloft.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1502 Lines: 40 On 08/31/2015 12:36 PM, David Miller wrote: > From: Alexei Starovoitov > Date: Mon, 31 Aug 2015 08:57:10 -0700 > >> To fix build errors: >> kernel/built-in.o: In function `bpf_trace_printk': >> bpf_trace.c:(.text+0x11a254): undefined reference to `strncpy_from_unsafe' >> kernel/built-in.o: In function `fetch_memory_string': >> trace_kprobe.c:(.text+0x11acf8): undefined reference to `strncpy_from_unsafe' >> >> move strncpy_from_unsafe() next to probe_kernel_read/write() >> which use the same memory access style. >> >> Reported-by: Fengguang Wu >> Reported-by: Guenter Roeck Too late, but: Tested-by: Guenter Roeck Guenter >> Fixes: 1a6877b9c0c2 ("lib: introduce strncpy_from_unsafe()") >> Signed-off-by: Alexei Starovoitov >> --- >> For configs without kprobes and bpf the cost of this unused function is >> ~200 bytes which I think is a better trade off vs creating >> new Kconfig selector just for this single function. >> Another alternative is to move it to kernel/trace/trace_kprobe.c, >> but then it will lose generality and probably should be removed >> from include/linux/uaccess.h, so mm/maccess.c looks the best. > > Ok, applied. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/