Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753408AbbHaV3B (ORCPT ); Mon, 31 Aug 2015 17:29:01 -0400 Received: from mga02.intel.com ([134.134.136.20]:61364 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751815AbbHaV3A convert rfc822-to-8bit (ORCPT ); Mon, 31 Aug 2015 17:29:00 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,444,1437462000"; d="scan'208";a="552498390" From: "Liang, Kan" To: Arnaldo Carvalho de Melo CC: Jiri Olsa , "jolsa@kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 1/1] perf,tools: open event on evsel cpus and threads Thread-Topic: [PATCH 1/1] perf,tools: open event on evsel cpus and threads Thread-Index: AQHQ3Ba3h3+eyXi/YUuLBXohgujFgp4V84oAgBAmI4CAAIaEwP//hZeAgACItsA= Date: Mon, 31 Aug 2015 21:28:43 +0000 Message-ID: <37D7C6CF3E00A74B8858931C1DB2F077018F5564@SHSMSX103.ccr.corp.intel.com> References: <1440138194-17001-1-git-send-email-kan.liang@intel.com> <20150821135436.GD27650@krava.brq.redhat.com> <20150831203115.GI4423@kernel.org> <37D7C6CF3E00A74B8858931C1DB2F077018F5548@SHSMSX103.ccr.corp.intel.com> <20150831211435.GK4423@kernel.org> In-Reply-To: <20150831211435.GK4423@kernel.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3379 Lines: 105 > > Em Mon, Aug 31, 2015 at 09:06:29PM +0000, Liang, Kan escreveu: > > > > > > > Em Fri, Aug 21, 2015 at 03:54:36PM +0200, Jiri Olsa escreveu: > > > > On Fri, Aug 21, 2015 at 02:23:14AM -0400, kan.liang@intel.com wrote: > > > > > From: Kan Liang > > > > > > > > > > evsel may have different cpus and threads as evlist's. > > > > > Use it's own cpus and threads, when open evsel in perf record. > > > > > > > > Acked-by: Jiri Olsa > > > > > > Applying, I wonder if this isn't affecting other tools as well... > > > And also > > > > No, it doesn't affect other tools. > > > > > perf_evlist__open(), that has to be fixed as well, right? > > > > > > > Umm... Right. > > We should fix it in perf_evlist__open as well. > > IIRC, Jirka once planned to send out a cleanup patch separately for > > this kind of issue (perf_evsel__enable also need to be fixed) on other > > tools. > > So now that we have a backpointer, perhaps we should have a: > > struct thread_map *perf_evsel__threads(struct perf_evsel *evsel) { > return evsel->threads ?: evsel->evlist ? evsel->evlist->threads : > NULL; } > > Ditto for cpus and then change all occurrences of evsel->threads with > perf_evsel__threads(), right? No. We need to change all evlist->threads with evsel->threads. Ditto for cpus. The event should use its own thread/cpu list. > > > Thanks, > > Kan > > > > > - Arnaldo > > > > > > > thanks, > > > > jirka > > > > > > > > > > > > > > Signed-off-by: Kan Liang > > > > > --- > > > > > tools/perf/builtin-record.c | 2 +- > > > > > tools/perf/util/evlist.c | 4 ++++ > > > > > 2 files changed, 5 insertions(+), 1 deletion(-) > > > > > > > > > > diff --git a/tools/perf/builtin-record.c > > > > > b/tools/perf/builtin-record.c index 25cf6b4..a0178bf 100644 > > > > > --- a/tools/perf/builtin-record.c > > > > > +++ b/tools/perf/builtin-record.c > > > > > @@ -279,7 +279,7 @@ static int record__open(struct record *rec) > > > > > > > > > > evlist__for_each(evlist, pos) { > > > > > try_again: > > > > > - if (perf_evsel__open(pos, evlist->cpus, evlist- > >threads) < > > > 0) { > > > > > + if (perf_evsel__open(pos, pos->cpus, pos- > >threads) < 0) { > > > > > if (perf_evsel__fallback(pos, errno, msg, > > > sizeof(msg))) { > > > > > if (verbose) > > > > > ui__warning("%s\n", msg); > > > > > diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c > > > > > index 373f65b..be6fde9 100644 > > > > > --- a/tools/perf/util/evlist.c > > > > > +++ b/tools/perf/util/evlist.c > > > > > @@ -1179,6 +1179,10 @@ int perf_evlist__apply_filters(struct > > > perf_evlist *evlist, struct perf_evsel **e > > > > > if (evsel->filter == NULL) > > > > > continue; > > > > > > > > > > + /* > > > > > + * filters only work for tracepoint event, which > doesn't > > > have cpu limit. > > > > > + * So evlist and evsel should always be same. > > > > > + */ > > > > > err = perf_evsel__apply_filter(evsel, ncpus, > nthreads, > > > evsel->filter); > > > > > if (err) { > > > > > *err_evsel = evsel; > > > > > -- > > > > > 1.8.3.1 > > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/