Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754240AbbIAAuE (ORCPT ); Mon, 31 Aug 2015 20:50:04 -0400 Received: from mail-by2on0109.outbound.protection.outlook.com ([207.46.100.109]:27676 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752883AbbIAAuA (ORCPT ); Mon, 31 Aug 2015 20:50:00 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=scottwood@freescale.com; Message-ID: <1441068591.4966.47.camel@freescale.com> Subject: Re: [RFC][PATCH 2/2] crypto: caam - handle core endianness != caam endianness From: Scott Wood To: Horia =?UTF-8?Q?Geant=C4=83?= CC: Herbert Xu , Catalin Marinas , Will Deacon , , "David S. Miller" , , , Victoria Milhoan , Steve Cornelius , Fabio Estevam , Alex Porosanu Date: Mon, 31 Aug 2015 19:49:51 -0500 In-Reply-To: <1440762608-7866-1-git-send-email-horia.geanta@freescale.com> References: <1440762306-7764-1-git-send-email-horia.geanta@freescale.com> <1440762608-7866-1-git-send-email-horia.geanta@freescale.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.0-fta1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Originating-IP: [2601:448:8100:f9f:12bf:48ff:fe84:c9a0] X-ClientProxiedBy: BLUPR05CA0081.namprd05.prod.outlook.com (10.141.20.51) To BN3PR03MB1478.namprd03.prod.outlook.com (25.163.35.141) X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1478;2:kdpzIbVkaZ43HglT6GmHAHrzf4O+y/XGZZNoZwgq5BvbktQbg/rbz3EU0ibt5WevKb9InH32eH04Li5Aoyc45k7+PDNkpgsYeD4afvwpBsg1jLWTqj4sc8latbuivH21ViBxsrbtEd+7740uCTAAXKOgyfE+f/t8VeeWzVFVzl8=;3:XZHnl/sRmNLMK/UufZn4vw1KvwGevs2ES3h4XcmPuODRIOfIQBpe1BqPveyP/U2mTLMb5pJsVplVVWViIUlpva01EIqAj3GVKVaBAvrHrYi1KtmBCczdvYa8UwiSnSgjE27jy8KRT+JcjIdk5FsjQQ==;25:Fc4pXlYNyZopu4fK7xc08uT3bYDEqOHG13KaoBMsb77t3niB81De0qao3XBoZALDPGY1fum8Voe4UXD1Ry5sq5jZtVN953mostMBVsmGZ9M1vkvSrXWvEdKTVHBTVU0V0o7yAH+/A3btgdLkLVX27Yhd1g0WplpgimRavW0x7/em4b3UeFzIrecXgz3gy2xGfv2iCLuyV0gIFnqO/ofgWTtER0OgNbFO4vCX42duBMI88zQJeP2WejWZ3RfXFodvJ8q/tv0JGI83FSNYZZPm5A== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1478; X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1478;20:zymClDzMMCwHhwQ1/0fP/ye6As9o7cY8Y9uRbNn3hyZtncxhxCxswCrLz9VAtXnP1mmaXJU5b7oOo1kZAZdvzyicgyPiQW+h+Fayo6CgKMy+6zJrZ9/LuDbTbtq+DtiHMGBhtlY85WOwt+5iRiGNei6SSjUN3n/vX4s8jmXUzo1Z3V+ha1aEmc0iwkHUis7DjWiIdPE5smCHy9Z30e4tJ36STZLAERCCk4i+kbjsaOIvve4WnMZUv80MQFQwehrzkqdTBDT13Zu5fQHOzLsZsytyOUJBeyrQT8IEBZIZH87/U78xrZWzEGaZiePUDm9jRIa11+4Bxi/pRR+mQufwRhta+suvJxOcZgSDBAzkggzGZLEwLSVbEB4TWAp9NSQXRjJ5vXMeSVAvcuwk2i3xSEfBS5hZp+/TTP4DmFGdaTYh3dIKkLK0NYDrjCmFTI/80ZzhAEq/AeofzDb98ob1NZOMp2YX5mppVRETgDNlk23KXara3UVSNxIeyd/ScF3L;4:31rqZnPDNPcncad2FqrFi1yXKndtf22rTv/9+WszngmPmqQ9bpNZhcdCd0to8tKNCDcsZjgAVAnyjgs6WF+yByJAsaBR/iPIKT4j5YVvf4xDlCFMthZhcgqHmQdkDgN9WlcvfQXO3EEAM3p1BSN81NChmr90MMnEYKqYUglV/Xrs3WqCNPepe69Sf7LqI10+XH+hG2qpaqF5xaMWLeOv4KNLtDBzdW8q5gn5n8IY8uP3+CeyqUZTh2bdIB3LKhjPVOG944XsYi+npv+b1k8czytEhblVBtJuqNw9HVelAXhyfGPfLWW7PBg/nKfz06q7 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(8121501046)(5005006)(3002001);SRVR:BN3PR03MB1478;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1478; X-Forefront-PRVS: 06860EDC7B X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(24454002)(377424004)(189002)(199003)(81156007)(50466002)(4001540100001)(110136002)(5001830100001)(105586002)(5001960100002)(40100003)(33646002)(97736004)(4001450100002)(36756003)(77096005)(189998001)(68736005)(5820100001)(77156002)(106356001)(5004730100002)(62966003)(5007970100001)(101416001)(46102003)(107886002)(2950100001)(47776003)(5001860100001)(42186005)(50986999)(76176999)(87976001)(122386002)(23676002)(92566002)(86362001)(50226001)(64706001)(103116003)(99106002)(3826002)(5001840100002)(4001430100001);DIR:OUT;SFP:1102;SCL:1;SRVR:BN3PR03MB1478;H:[IPv6:2601:448:8100:f9f:12bf:48ff:fe84:c9a0];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjNQUjAzTUIxNDc4OzIzOnZWR3g0R2dIZjFIdTdmb2xIMkpadGlLdmU4?= =?utf-8?B?aEJrOXJiSGk5MVV5Ynowd3lrVjk2Wks3VkR5ZXFsSlJpNWp1WTNQeWFUU055?= =?utf-8?B?UFdMenoydDBmbDQrSGgrQ3AxckFML3JDVFhKTk5jaWpNamQ5NGlSV2IyOXFV?= =?utf-8?B?d0NjM1ZBNUZOYm9TM2RIYlNJQXl2a20vK3hHb0NXUjR3aGQ2Um9TcVREYkF2?= =?utf-8?B?bDAveGxHc3VqZWs1NUxmc0pTUmZDUW83bHdYL1FBOEVuV1lheHJvQkJKNHUw?= =?utf-8?B?NnRQQldtcnNCVlhUOHhDaW1jTG5sTmc3a3RDU2JTd253cm9kMEFUUHNIK0E5?= =?utf-8?B?aFpybEFidVVJdkswQWwvV3JKc3VQREtsR1FFZHNPNG9ETThVUWtNaXNlUlBh?= =?utf-8?B?U2N4UWpNZDJCRVJEY1dLMG9qYnhYV0VQTzVIdkttUzFkVkZkdWFYUTRlMFdR?= =?utf-8?B?Vm1SelRjWmZYYXo2ZmI4VFRFc1ptSEk2blNFZkxxT2U4MWJ5UkRsWWFZbzVo?= =?utf-8?B?RWRDNnVPTDhMd0crVlFaYmUxbFk3VlpqQ3FZa2FkVWxPcUlsNlFHT2Z4TWxQ?= =?utf-8?B?L0c0eEJIVTZESTBpYzNLRmI3OFRpZGlzV0tPK3dBYTFuM3orOVJGY2RqTzFI?= =?utf-8?B?amJLVzNVdlAwTWdTRGtSM25Sa2N1b1g2TW5YcjBxdkZrUUV6eU1PWkdHNlps?= =?utf-8?B?VjlVb1lCVGVtS2p4SzV0SlN2ZGZadmZ6THRpMEtPdFhNSTc5UkhpWXZJWGpD?= =?utf-8?B?TnpQL2tTaG54N0pHT0o3Ry9xQjBqTGlQZDV5YVlCcVNvZUY5TEE5RGJ3MjJM?= =?utf-8?B?ekZFYzN1TEcrNmRweFdkSW1oRWxBR1dNbmMxNCtrT2RDc1d2VHIzMUVSelVP?= =?utf-8?B?QlBtZ3lISjNzdUVrVi95TUNjeEZsdk5ScUVxa29hVWp1a0VCMjlBVjE3aE52?= =?utf-8?B?bDl3S0diWVV5L2srMW5nZldQQVh1bWdUSmJCc3o3V1E1dnp3Ukpyd1NTUi9S?= =?utf-8?B?Q3FtR25oVkErRnQ0a3pEL2FpU0lGbzRib1lsSnJyOWorUTgyKzZ0VTllS3Iz?= =?utf-8?B?OTdTVmVzV1dNNUtVVVdwbmRnbGNjQU1zaDB3ZUh0b3llQzcyZGMxdDhTaDdL?= =?utf-8?B?S3Mza3dSdFNLdmVyM3loQUN5UUJEMWdWQkIvU3E4ZDJxa0xJZXJQczVOUnNT?= =?utf-8?B?K3REZmFGcTBob2E5UUd4ZnJaN2ViaDJlNEQ5TFFZM1RqSkRqc2p6amFtY3Z2?= =?utf-8?B?N0xDMG1yRDhab1lKZnlpOGVOQnZWc2xZdnZWWGhWT2E2Tk9CR1dRMERTVTRW?= =?utf-8?B?Vi9rYVRaWUkwMzZCMW55aUkveHpReW13NHlXeDQ1b29BcmRtMUpwbSs0bExl?= =?utf-8?B?WXBERzRqZndLaXBuN1NJVi9GYkhFdXpDRXBBUlRjVTNDYUUzbWx6V095RDRz?= =?utf-8?B?c3drTEh2NDJodTlrRzZUL0dsYmtvemVjVFRvMTBoVUhvTjc5UHlKU2FvMXVF?= =?utf-8?B?cTlqOUNDc1RIcEZSbFc5eWhNS2l0WXZUaTRYaGtqcE5ZUkxQMGJjTEMzWGVj?= =?utf-8?B?Vkg1ZzBBa1ROa2dlMmhxamtiSWNiWjFpUFJ1QXdYQWpDalJSRmt6aVVrNTJJ?= =?utf-8?B?UTFmWXVYNG5jR2JRTTUzNXlqTjd3dXowUnJjSk5QVnBLbEFpZmdqNmZ1UllS?= =?utf-8?Q?RoDlTfzaqQZLJjxsp5xgABqhUn6cLeUOtrmp1nB?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1478;5:9GATvaPaw/0Vu4ARnxKeoBrdbok7gyKiwaS0EhPIXgkPOyO+fFawmI/dhxVK6NcuiLeBdjSCcAmJqK91Gc9vZx/9FAgSlwQf2FTY5U0GCyj9UUKykZ8GUM3JBjVjISX978Jg6xiJMHkCH363pQxorg==;24:PZKvIaJZlvQI0UhxrKoK3k2aM75I8fkmF09tasftRBDTi1SaNzcMjhmjK+G2UqG69RdLbHmcVZrcFHzvALlOd+y1eX/A64TaLnQi1WDXXxo=;20:H++iekTiGvgMRF4S14EwKqMnNpHO9s1dPQimHOrxQ8aaSe1gXUIv27WgORh7vIhsz+TYZVLMOlm9bW0/W4ROwA== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2015 00:49:57.4507 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1478 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1078 Lines: 29 On Fri, 2015-08-28 at 14:50 +0300, Horia Geantă wrote: > > -#ifdef __BIG_ENDIAN > -#define wr_reg32(reg, data) out_be32(reg, data) > -#define rd_reg32(reg) in_be32(reg) > +#ifdef CONFIG_CRYPTO_DEV_FSL_CAAM_LE > +#define caam16_to_cpu(value) le16_to_cpu(value) > +#define cpu_to_caam16(value) cpu_to_le16(value) > +#define caam32_to_cpu(value) le32_to_cpu(value) > +#define cpu_to_caam32(value) cpu_to_le32(value) > +#define caam64_to_cpu(value) le64_to_cpu(value) > +#define cpu_to_caam64(value) cpu_to_le64(value) What if we want to build a kernel that supports a chip with an LE CAAM and another chip with a BE CAAM (e.g. ls1043a plus ls2080a)? This information needs to come at runtime. > +#ifdef CONFIG_ARCH_DMA_ADDR_T_64BIT > +#ifdef CONFIG_SOC_IMX7D Likewise, why is there an ifdef for a particular SoC type? -Scott -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/