Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752488AbbKANMX (ORCPT ); Sun, 1 Nov 2015 08:12:23 -0500 Received: from unicorn.mansr.com ([81.2.72.234]:38366 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751895AbbKANMU convert rfc822-to-8bit (ORCPT ); Sun, 1 Nov 2015 08:12:20 -0500 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Wolfram Sang Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org Subject: Re: [PATCH 2/2] i2c: add driver for Sigma Designs SMP8642 I2C master References: <1446312957-18744-1-git-send-email-mans@mansr.com> <1446312957-18744-2-git-send-email-mans@mansr.com> <20151101064228.GA2010@katana> Date: Sun, 01 Nov 2015 13:12:11 +0000 In-Reply-To: <20151101064228.GA2010@katana> (Wolfram Sang's message of "Sun, 1 Nov 2015 07:42:29 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1600 Lines: 42 Wolfram Sang writes: > On Sat, Oct 31, 2015 at 05:35:57PM +0000, Mans Rullgard wrote: >> This adds a driver for the Sigma Designs SMP8642 built-in I2C master >> controller. The hardware is very similar to the I2C controller in the >> Ralink RT3050 chip with the addition of interrupt generation and an >> inverted busy/idle status bit. There are typically two controllers with >> a shared IRQ. >> >> Signed-off-by: Mans Rullgard > > Thanks for the driver. Same answer as here, though: > > http://www.spinics.net/lists/linux-i2c/msg17001.html > >> +#define TANGOX_I2C_CONFIG 0x00 >> +#define TANGOX_I2C_CLKDIV 0x04 >> +#define TANGOX_I2C_DEVADDR 0x08 >> +#define TANGOX_I2C_ADDR 0x0c >> +#define TANGOX_I2C_DATAOUT 0x10 >> +#define TANGOX_I2C_DATAIN 0x14 >> +#define TANGOX_I2C_STATUS 0x18 >> +#define TANGOX_I2C_STARTXFER 0x1c >> +#define TANGOX_I2C_BYTECNT 0x20 >> +#define TANGOX_I2C_INT_EN 0x24 >> +#define TANGOX_I2C_INT_STAT 0x28 > > The register set looks like the one from i2c-xlr.c, only that they are > 32 bit apart instead of 8. Can you check if you can reuse that driver? It does look very similar indeed. I thought I'd checked for an existing driver, but apparently I missed that one. I'll modify the xlr driver to handle this hardware as well instead. -- M?ns Rullg?rd mans@mansr.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/