Subject: Re: [PATCH v4 2/6] clk: sunxi: Add H3 clocks support
To: Arnd Bergmann <arnd@arndb.de>, linux-arm-kernel@lists.infradead.org
References: <1445964626-6484-1-git-send-email-jenskuske@gmail.com>
 <1445964626-6484-3-git-send-email-jenskuske@gmail.com>
 <3751073.AWmm18dvKK@wuerfel>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>,
        Chen-Yu Tsai <wens@csie.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        =?UTF-8?Q?Emilio_L=c3=b3pez?= <emilio@elopez.com.ar>,
        devicetree@vger.kernel.org,
        Vishnu Patekar <vishnupatekar0510@gmail.com>,
        linux-kernel@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
        linux-sunxi@googlegroups.com
From: Jens Kuske <jenskuske@gmail.com>
Message-ID: <56361656.2040100@gmail.com>
Date: Sun, 1 Nov 2015 14:40:38 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <3751073.AWmm18dvKK@wuerfel>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1349
Lines: 36

Hi,

On 30/10/15 09:28, Arnd Bergmann wrote:
> On Tuesday 27 October 2015 17:50:22 Jens Kuske wrote:
>> +               of_property_read_string_index(node, "clock-output-names",
>> +                                             i, &clk_name);
>> +
>> +               if (index == 17 || (index >= 29 && index <= 31))
>> +                       clk_parent = AHB2;
>> +               else if (index <= 63 || index >= 128)
>> +                       clk_parent = AHB1;
>> +               else if (index >= 64 && index <= 95)
>> +                       clk_parent = APB1;
>> +               else if (index >= 96 && index <= 127)
>> +                       clk_parent = APB2;
>> +
>> +               clk_reg = reg + 4 * (index / 32);
>>
> 
> Same as for the reset driver, this probably means you should have one
> cell to indicate which bus it is for, and another cell for the
> index.
> 

This is what Maxime suggested in an earlier version:
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-May/344213.html

In between I had another version with the parents in DT, but he
didn't like that too.

Jens
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/