Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752534AbbKAPwL (ORCPT ); Sun, 1 Nov 2015 10:52:11 -0500 Received: from mail.tpi.com ([74.45.170.26]:37775 "EHLO mail.tpi.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751292AbbKAPwI (ORCPT ); Sun, 1 Nov 2015 10:52:08 -0500 X-Greylist: delayed 487 seconds by postgrey-1.27 at vger.kernel.org; Sun, 01 Nov 2015 10:52:08 EST Subject: Re: [PATCH v4.3-rc7] be2iscsi : Fix bogus WARN_ON length check To: Johannes Thumshirn References: <1446229378-2956-1-git-send-email-tim.gardner@canonical.com> Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Jayamohan Kallickal , Minh Tran , John Soni Jose , "James E.J. Bottomley" From: Tim Gardner Message-ID: <5636333F.7000903@canonical.com> Date: Sun, 1 Nov 2015 08:43:59 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1269 Lines: 35 On 10/30/2015 02:59 PM, Johannes Thumshirn wrote: > Hi Tim, > tim.gardner@canonical.com writes: > >> From: Tim Gardner >> >> drivers/scsi/be2iscsi/be_main.c: In function 'be_sgl_create_contiguous': >> drivers/scsi/be2iscsi/be_main.c:3187:18: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses] >> WARN_ON(!length > 0); >> >> gcc version 5.2.1 > > This patch (or similar) was already posted on Oct 1 by Joel Stanley. > See http://comments.gmane.org/gmane.linux.scsi/105462 > > Thanks, > Johannes > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > Mechanical application of prarens makes that expression more complicated then it needs to be. It is, after all, an unsigned integer. rtg -- Tim Gardner tim.gardner@canonical.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/