From: Ley Foon Tan <lftan@altera.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
CC: Bjorn Helgaas <bhelgaas@google.com>,
        "linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the pci tree
Thread-Topic: linux-next: build failure after merge of the pci tree
Thread-Index: AQHRFQF21oVOCW+R802N5njFBysjpg==
Date: Mon, 2 Nov 2015 00:00:19 +0000
Message-ID: <E7E66AD1AD65064486AD57C361DF091C05C7B391@PG-ITEXCH01.altera.priv.altera.com>
References: <20151102022307.774bde2c@canb.auug.org.au>
In-Reply-To: <20151102022307.774bde2c@canb.auug.org.au>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2015 00:00:25.2221
 (UTC)
X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.227];Helo=[sj-itexedge03.altera.priv.altera.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR03MB382
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id tA2017lS028366
Content-Length: 2130
Lines: 58

On Isn, 2015-11-02 at 02:23 +1100, Stephen Rothwell wrote:
> Hi Bjorn,
>
> After merging the pci tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> In file included from include/linux/kvm_host.h:20:0,
>                  from arch/powerpc/kernel/asm-offsets.c:54:
> include/linux/msi.h:174:21: fatal error: asm/msi.h: No such file or directory
>
> Caused by commit
>
>   f19eafec930f ("PCI: altera: Add Altera PCIe MSI driver")
>
> I have disabled that driver for today:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 2 Nov 2015 02:12:54 +1100
> Subject: [PATCH] PCI: altera: disable MSI driver for now
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/pci/host/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index 2af0571356e8..7a31ebbc4379 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -158,6 +158,7 @@ config PCIE_ALTERA
>  config PCIE_ALTERA_MSI
>       bool "Altera PCIe MSI feature"
>       depends on PCI_MSI
> +     depends on BROKEN
>       select PCI_MSI_IRQ_DOMAIN
>       help
>         Say Y here if you want PCIe MSI support for the Altera FPGA.
> --
> 2.6.1
>
Hi Bjorn

This driver depends on the asm/msi.h and not all architectures include
the asm/msi.h.
We can fix this by adding "depends on ARM || NIOS2" to Kconfig, same as
altera pcie driver. What do you think?

Thanks.

Regards
Ley Foon


________________________________

Confidentiality Notice.
This message may contain information that is confidential or otherwise protected from disclosure. If you are not the intended recipient, you are hereby notified that any use, disclosure, dissemination, distribution, or copying of this message, or any attachments, is strictly prohibited. If you have received this message in error, please advise the sender by reply e-mail, and delete the message and any attachments. Thank you.
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?