Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751714AbbKBCaf (ORCPT ); Sun, 1 Nov 2015 21:30:35 -0500 Received: from mail-wm0-f45.google.com ([74.125.82.45]:35466 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750884AbbKBCac (ORCPT ); Sun, 1 Nov 2015 21:30:32 -0500 MIME-Version: 1.0 Date: Sun, 1 Nov 2015 19:30:30 -0700 Message-ID: Subject: [PATCH] toshiba_acpi: Initialize hotkey_event_type variable From: Azael Avalos To: Darren Hart , "platform-driver-x86@vger.kernel.org" , "linux-kernel@vger.kernel.org" Cc: Azael Avalos , stable@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1397 Lines: 38 Commit 23f8f4326a15 ("toshiba_acpi: Fix hotkeys registration on some toshiba models") fixed an issue on some laptops regarding hotkeys registration, however, if failed to address the initialization of the hotkey_event_type variable, and thus, it can lead to potential unwanted effects as the variable is being checked. This patch initializes such variable to avoid such unwanted effects. Cc: # 4.1+ Signed-off-by: Azael Avalos --- Darren, Sorry for sending this patch this late, I had a really busy week :-( drivers/platform/x86/toshiba_acpi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c index beb709f..c013029 100644 --- a/drivers/platform/x86/toshiba_acpi.c +++ b/drivers/platform/x86/toshiba_acpi.c @@ -2665,6 +2665,7 @@ static int toshiba_acpi_add(struct acpi_device *acpi_dev) ret = toshiba_function_keys_get(dev, &dev->special_functions); dev->kbd_function_keys_supported = !ret; + dev->hotkey_event_type = 0; if (toshiba_acpi_setup_keyboard(dev)) pr_info("Unable to activate hotkeys\n"); -- 2.6.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/