Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752211AbbKBGXz (ORCPT ); Mon, 2 Nov 2015 01:23:55 -0500 Received: from smtprelay2.synopsys.com ([198.182.60.111]:52999 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751903AbbKBGXy convert rfc822-to-8bit (ORCPT ); Mon, 2 Nov 2015 01:23:54 -0500 From: Vineet Gupta To: Noam Camus , "linux-snps-arc@lists.infradead.org" CC: "cmetcalf@ezchip.com" , "gilf@ezchip.com" , "talz@ezchip.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v1 07/20] ARC: mm: use generic macros _BITUL() Thread-Topic: [PATCH v1 07/20] ARC: mm: use generic macros _BITUL() Thread-Index: AQHRE97SdJ01mANsb0Wt8bBQwOLYvg== Date: Mon, 2 Nov 2015 06:23:49 +0000 Message-ID: References: <1446297327-16298-1-git-send-email-noamc@ezchip.com> <1446297327-16298-8-git-send-email-noamc@ezchip.com> Accept-Language: en-US, en-IN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.12.197.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1277 Lines: 35 On Saturday 31 October 2015 06:49 PM, Noam Camus wrote: > From: Noam Camus > > PGDIR_SIZE() cannot use "1UL" since it is called from mm/tlbex.S > by VMALLOC_START. _BITUL() solves this build error. > > Signed-off-by: Noam Camus > --- > arch/arc/include/asm/pgtable.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/arc/include/asm/pgtable.h b/arch/arc/include/asm/pgtable.h > index 57af2f0..372a282 100644 > --- a/arch/arc/include/asm/pgtable.h > +++ b/arch/arc/include/asm/pgtable.h > @@ -210,7 +210,7 @@ > #define BITS_FOR_PGD (32 - BITS_FOR_PTE - BITS_IN_PAGE) > > #define PGDIR_SHIFT (32 - BITS_FOR_PGD) > -#define PGDIR_SIZE (1UL << PGDIR_SHIFT) /* vaddr span, not PDG sz */ > +#define PGDIR_SIZE _BITUL(PGDIR_SHIFT) /* vaddr span, not PDG sz */ > #define PGDIR_MASK (~(PGDIR_SIZE-1)) > > #define PTRS_PER_PTE _BITUL(BITS_FOR_PTE) For bisectability, please squash this with patch 4/20, and append the changelog of this patch to 4/20 -Vineet -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/