Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752362AbbKBGye (ORCPT ); Mon, 2 Nov 2015 01:54:34 -0500 Received: from smtprelay2.synopsys.com ([198.182.60.111]:53459 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751604AbbKBGyd convert rfc822-to-8bit (ORCPT ); Mon, 2 Nov 2015 01:54:33 -0500 From: Vineet Gupta To: Alexey Brodkin , "linux-snps-arc@lists.infradead.org" CC: "linux-kernel@vger.kernel.org" , Rob Herring Subject: Re: [PATCH] arc: dts - remove default value if CONFIG_ARC_BUILTIN_DTB_NAME is blank Thread-Topic: [PATCH] arc: dts - remove default value if CONFIG_ARC_BUILTIN_DTB_NAME is blank Thread-Index: AQHRFDLbY3Mvd/dhvkmphLiRXFYn2g== Date: Mon, 2 Nov 2015 06:54:28 +0000 Message-ID: References: <1446333671-32095-1-git-send-email-abrodkin@synopsys.com> Accept-Language: en-US, en-IN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.12.197.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2469 Lines: 71 On Sunday 01 November 2015 04:51 AM, Alexey Brodkin wrote: > As of today default .dtb will be built (and subsequently will be built-in > kernel binary) even if CONFIG_ARC_BUILTIN_DTB_NAME is not set. > > But it is possible we're going to use external .dtb and so we don't want to > have .dtb built-in kernel binary. > > For example that could be the case with: > a) U-Boot which loads .dtb in DDR and passes its address to the kernel > b) OpenWRT which embeds .dtb in existing kernel binary > > This change excludes .dtb building if CONFIG_ARC_BUILTIN_DTB_NAME is > blank. > > Signed-off-by: Alexey Brodkin > Cc: Vineet Gupta Rob has been doing a series to build all DTBs and he also provided a fix to ARC makefiles to use common make variables which collides with ur patch. @Alexey, can u wait until rc1 comes out and rebase it on top, assuming Rob's series is merged in 4.4 window ? If his doesn't, I will merge this as it is for rc2 ! -Vineet > --- > arch/arc/Makefile | 2 ++ > arch/arc/boot/dts/Makefile | 6 ++---- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arc/Makefile b/arch/arc/Makefile > index 8a27a48..b0cb6de 100644 > --- a/arch/arc/Makefile > +++ b/arch/arc/Makefile > @@ -94,7 +94,9 @@ head-y := arch/arc/kernel/head.o > core-y += arch/arc/ > > # w/o this dtb won't embed into kernel binary > +ifneq ($(CONFIG_ARC_BUILTIN_DTB_NAME),"") > core-y += arch/arc/boot/dts/ > +endif > > core-$(CONFIG_ARC_PLAT_SIM) += arch/arc/plat-sim/ > core-$(CONFIG_ARC_PLAT_TB10X) += arch/arc/plat-tb10x/ > diff --git a/arch/arc/boot/dts/Makefile b/arch/arc/boot/dts/Makefile > index b0e3f19..4dcab5b 100644 > --- a/arch/arc/boot/dts/Makefile > +++ b/arch/arc/boot/dts/Makefile > @@ -1,13 +1,11 @@ > # Built-in dtb > -builtindtb-y := nsim_700 > > ifneq ($(CONFIG_ARC_BUILTIN_DTB_NAME),"") > builtindtb-y := $(patsubst "%",%,$(CONFIG_ARC_BUILTIN_DTB_NAME)) > + obj-y += $(builtindtb-y).dtb.o > + targets += $(builtindtb-y).dtb > endif > > -obj-y += $(builtindtb-y).dtb.o > -targets += $(builtindtb-y).dtb > - > .SECONDARY: $(obj)/$(builtindtb-y).dtb.S > > dtbs: $(addprefix $(obj)/, $(builtindtb-y).dtb) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/