Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751811AbbKBHof (ORCPT ); Mon, 2 Nov 2015 02:44:35 -0500 Received: from mail-yk0-f179.google.com ([209.85.160.179]:34846 "EHLO mail-yk0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751332AbbKBHoa (ORCPT ); Mon, 2 Nov 2015 02:44:30 -0500 MIME-Version: 1.0 Date: Mon, 2 Nov 2015 13:14:29 +0530 Message-ID: Subject: Re: [PATCH 5/7] clocksource/drivers/pxa_timer: Move the Kconfig rule From: Amit Kucheria To: Daniel Lezcano Cc: Thomas Gleixner , John Stultz , LKML , Russell King , "moderated list:ARM PORT" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2038 Lines: 58 On Fri, Oct 30, 2015 at 4:22 AM, Daniel Lezcano wrote: > Instead of having the clocksource's Kconfig depending on the arch, let the > arch to select the timer it needs. Is this the prescribed way to do things nowadays? It leads to more options showing up in 'make menuconfig'. Why do I need to see CLKSRC_PXA if I'm not even compiling for ARCH_PXA (and not interesting in COMPILE_TEST)? > The CLKSRC_OF dependency is removed because already selected by the ARCH_PXA, > and it is added for SA1100. This bit makes sense. > Signed-off-by: Daniel Lezcano > --- > arch/arm/Kconfig | 3 +++ > drivers/clocksource/Kconfig | 3 +-- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 72ad724..aa32286 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -609,6 +609,7 @@ config ARCH_PXA > select AUTO_ZRELADDR > select COMMON_CLK > select CLKDEV_LOOKUP > + select CLKSRC_PXA > select CLKSRC_MMIO > select CLKSRC_OF > select GENERIC_CLOCKEVENTS > @@ -669,6 +670,8 @@ config ARCH_SA1100 > select ARCH_SPARSEMEM_ENABLE > select CLKDEV_LOOKUP > select CLKSRC_MMIO > + select CLKSRC_PXA > + select CLKSRC_OF if OF > select CPU_FREQ > select CPU_SA1100 > select GENERIC_CLOCKEVENTS > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig > index 5cd000c..425abbd 100644 > --- a/drivers/clocksource/Kconfig > +++ b/drivers/clocksource/Kconfig > @@ -289,8 +289,7 @@ config CLKSRC_TANGO_XTAL > select CLKSRC_OF > > config CLKSRC_PXA > - def_bool y if ARCH_PXA || ARCH_SA1100 > - select CLKSRC_OF if OF > + bool -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/