Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752733AbbKBIDW (ORCPT ); Mon, 2 Nov 2015 03:03:22 -0500 Received: from mail-wi0-f180.google.com ([209.85.212.180]:34304 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752053AbbKBIDT (ORCPT ); Mon, 2 Nov 2015 03:03:19 -0500 Subject: Re: [PATCH 5/7] clocksource/drivers/pxa_timer: Move the Kconfig rule To: Amit Kucheria References: Cc: Thomas Gleixner , John Stultz , LKML , Russell King , "moderated list:ARM PORT" From: Daniel Lezcano Message-ID: <563718C4.5050503@linaro.org> Date: Mon, 2 Nov 2015 09:03:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2609 Lines: 79 Hi Amit, On 11/02/2015 08:44 AM, Amit Kucheria wrote: > On Fri, Oct 30, 2015 at 4:22 AM, Daniel Lezcano > wrote: >> Instead of having the clocksource's Kconfig depending on the arch, let the >> arch to select the timer it needs. > > Is this the prescribed way to do things nowadays? It leads to more > options showing up in 'make menuconfig'. Why do I need to see > CLKSRC_PXA if I'm not even compiling for ARCH_PXA (and not interesting > in COMPILE_TEST)? That won't happen. As the 'bool' has no string after, it won't show up in the menuconfig. Actually, with the next patch, only COMPILE_TEST will show it up in the Device Drivers->Clocksource drivers. >> The CLKSRC_OF dependency is removed because already selected by the ARCH_PXA, >> and it is added for SA1100. > > This bit makes sense. > >> Signed-off-by: Daniel Lezcano >> --- >> arch/arm/Kconfig | 3 +++ >> drivers/clocksource/Kconfig | 3 +-- >> 2 files changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig >> index 72ad724..aa32286 100644 >> --- a/arch/arm/Kconfig >> +++ b/arch/arm/Kconfig >> @@ -609,6 +609,7 @@ config ARCH_PXA >> select AUTO_ZRELADDR >> select COMMON_CLK >> select CLKDEV_LOOKUP >> + select CLKSRC_PXA >> select CLKSRC_MMIO >> select CLKSRC_OF >> select GENERIC_CLOCKEVENTS >> @@ -669,6 +670,8 @@ config ARCH_SA1100 >> select ARCH_SPARSEMEM_ENABLE >> select CLKDEV_LOOKUP >> select CLKSRC_MMIO >> + select CLKSRC_PXA >> + select CLKSRC_OF if OF >> select CPU_FREQ >> select CPU_SA1100 >> select GENERIC_CLOCKEVENTS >> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig >> index 5cd000c..425abbd 100644 >> --- a/drivers/clocksource/Kconfig >> +++ b/drivers/clocksource/Kconfig >> @@ -289,8 +289,7 @@ config CLKSRC_TANGO_XTAL >> select CLKSRC_OF >> >> config CLKSRC_PXA >> - def_bool y if ARCH_PXA || ARCH_SA1100 >> - select CLKSRC_OF if OF >> + bool -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/