Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753434AbbKBJIj (ORCPT ); Mon, 2 Nov 2015 04:08:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54075 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753385AbbKBJIg (ORCPT ); Mon, 2 Nov 2015 04:08:36 -0500 Date: Mon, 2 Nov 2015 04:08:32 -0500 From: Jessica Yu To: Jiri Kosina Cc: Chris J Arges , live-patching@vger.kernel.org, Josh Poimboeuf , Seth Jennings , Vojtech Pavlik , linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: livepatch: old_name@old_addr scheme in livepatch sysfs directory Message-ID: <20151102090832.GB24801@packer-debian-8-amd64.digitalocean.com> References: <1446263060-22175-1-git-send-email-chris.j.arges@canonical.com> <20151101015258.GA8199@packer-debian-8-amd64.digitalocean.com> <56358EA4.10900@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-OS: Linux eisen.io 3.16.0-4-amd64 x86_64 User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 838 Lines: 20 +++ Jiri Kosina [01/11/15 10:07 +0100]: >On Sat, 31 Oct 2015, Chris J Arges wrote: > >> Makes sense to me. Is there a reason why the sysfs entries are visible >> to non-root users? > >Well, kptr_restrict applies only to values printed using '%pK'. So if the >sysfs handler is using other printk() format string to print the pointer, >it'll be leaked out (and should eventually be fixed). Hm, I think the func.n solution might be a good temporary fix for now. Even if we do go with func@addr and use the '%pK' format specifier we will run into the same problem at kptr_restrict == 2. Jessica -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/