Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753539AbbKBKVO (ORCPT ); Mon, 2 Nov 2015 05:21:14 -0500 Received: from mga14.intel.com ([192.55.52.115]:47418 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752755AbbKBKVM (ORCPT ); Mon, 2 Nov 2015 05:21:12 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,234,1444719600"; d="scan'208";a="840998193" Date: Mon, 2 Nov 2015 15:54:40 +0530 From: Vinod Koul To: Peter Ujfalusi Cc: nsekhar@ti.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, tony@atomide.com, olof@lixom.net Subject: Re: [PATCH] ARM: OMAP: hwmod: AM33xx/43xx: Add HWMOD_INIT_NO_IDLE flag to tptc Message-ID: <20151102102440.GM21326@localhost> References: <1446459060-16220-1-git-send-email-peter.ujfalusi@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1446459060-16220-1-git-send-email-peter.ujfalusi@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2532 Lines: 70 On Mon, Nov 02, 2015 at 12:11:00PM +0200, Peter Ujfalusi wrote: > In Linux we do not have driver for TPTCs of eDMA3 since there is no need to > do any configuration within TPTC for the eDMA3 to be operational. All > configuration is via the TPCC. > To prevent the omap_device_late_idle() to disable the TPTCs when they are > no longer bind with the edma driver, the HWMOD_INIT_NO_IDLE need to be > added. > > Signed-off-by: Peter Ujfalusi > --- > Vinod, Olof, > > This patch somehow got lost in my working branch. It was mixed within the patches > I will have for 4.5 while it should have been within the new eDMA3 binding > series.. Does this fix the issue reported by Olof? Also ACK pls for this -- ~Vinod > > Regards, > Peter > > arch/arm/mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c > index 907a452b78ea..3c7106a09801 100644 > --- a/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c > +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c > @@ -1169,7 +1169,8 @@ struct omap_hwmod am33xx_tptc0_hwmod = { > .name = "tptc0", > .class = &am33xx_tptc_hwmod_class, > .clkdm_name = "l3_clkdm", > - .flags = HWMOD_SWSUP_SIDLE | HWMOD_SWSUP_MSTANDBY, > + .flags = (HWMOD_SWSUP_SIDLE | HWMOD_SWSUP_MSTANDBY | > + HWMOD_INIT_NO_IDLE), > .main_clk = "l3_gclk", > .prcm = { > .omap4 = { > @@ -1183,7 +1184,8 @@ struct omap_hwmod am33xx_tptc1_hwmod = { > .name = "tptc1", > .class = &am33xx_tptc_hwmod_class, > .clkdm_name = "l3_clkdm", > - .flags = (HWMOD_SWSUP_SIDLE | HWMOD_SWSUP_MSTANDBY), > + .flags = (HWMOD_SWSUP_SIDLE | HWMOD_SWSUP_MSTANDBY | > + HWMOD_INIT_NO_IDLE), > .main_clk = "l3_gclk", > .prcm = { > .omap4 = { > @@ -1197,7 +1199,8 @@ struct omap_hwmod am33xx_tptc2_hwmod = { > .name = "tptc2", > .class = &am33xx_tptc_hwmod_class, > .clkdm_name = "l3_clkdm", > - .flags = (HWMOD_SWSUP_SIDLE | HWMOD_SWSUP_MSTANDBY), > + .flags = (HWMOD_SWSUP_SIDLE | HWMOD_SWSUP_MSTANDBY | > + HWMOD_INIT_NO_IDLE), > .main_clk = "l3_gclk", > .prcm = { > .omap4 = { > -- > 2.6.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/