Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752938AbbKBLAV (ORCPT ); Mon, 2 Nov 2015 06:00:21 -0500 Received: from mx2.suse.de ([195.135.220.15]:41680 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751914AbbKBLAT (ORCPT ); Mon, 2 Nov 2015 06:00:19 -0500 Date: Mon, 2 Nov 2015 20:00:14 +0900 From: Joerg Roedel To: kernel test robot Cc: Baoquan He , lkp@01.org, LKML Subject: [PATCH] iommu/vt-d: Fix return value check of parse_ioapics_under_ir() Message-ID: <20151102110014.GC2704@suse.de> References: <87h9l494nd.fsf@yhuang-dev.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87h9l494nd.fsf@yhuang-dev.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1669 Lines: 46 On Mon, Nov 02, 2015 at 04:39:18PM +0800, kernel test robot wrote: > FYI, we noticed the below changes on > > https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git x86/vt-d > commit a13c8f27e4d79420ae7bcb48123fa13851026428 ("iommu/vt-d: Adjust the return value of the parse_ioapics_under_ir") > > We found the following new message in kernel log. > > [ 0.126325] DMAR-IR: Failed to enable irq remapping. You are vulnerable to irq-injection attacks. Thanks for the report, I just queued the fix below. >From b61e5e80e3cd37f0183cdc04b03861a0467d9f52 Mon Sep 17 00:00:00 2001 From: Joerg Roedel Date: Mon, 2 Nov 2015 19:57:31 +0900 Subject: [PATCH] iommu/vt-d: Fix return value check of parse_ioapics_under_ir() The function returns 0 on success, so check for the right value. Signed-off-by: Joerg Roedel --- drivers/iommu/intel_irq_remapping.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/intel_irq_remapping.c b/drivers/iommu/intel_irq_remapping.c index f3a9bd1..1fae188 100644 --- a/drivers/iommu/intel_irq_remapping.c +++ b/drivers/iommu/intel_irq_remapping.c @@ -690,7 +690,7 @@ static int __init intel_prepare_irq_remapping(void) if (!dmar_ir_support()) return -ENODEV; - if (!parse_ioapics_under_ir()) { + if (parse_ioapics_under_ir()) { pr_info("Not enabling interrupt remapping\n"); goto error; } -- 1.8.4.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/