Message-ID: <56376389.8030806@collabora.co.uk>
Date: Mon, 02 Nov 2015 13:22:17 +0000
From: Martyn Welch <martyn.welch@collabora.co.uk>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0
MIME-Version: 1.0
To: Lee Jones <lee.jones@linaro.org>
CC: linux-tegra@vger.kernel.org, thierry.reding@gmail.com,
        swarren@wwwdotorg.org, jonathanh@nvidia.com,
        linux-kernel@vger.kernel.org, abrestic@chromium.org
Subject: Re: [RFC 7/8] Start migrating XUSB away from MFD
References: <1446465323-9493-1-git-send-email-martyn.welch@collabora.co.uk> <1446465323-9493-8-git-send-email-martyn.welch@collabora.co.uk> <20151102124732.GW4058@x1>
In-Reply-To: <20151102124732.GW4058@x1>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1625
Lines: 40


On 02/11/15 12:47, Lee Jones wrote:
> On Mon, 02 Nov 2015, Martyn Welch wrote:
>
>> From: Martyn Welch <martyn@welchs.me.uk>
>>
>> This is my initial attempt to get xusb working without being a MFD on the
>> latest upstream kernel. It's still a bit hacky in places, but does seem to
>> get the USB2 up and working (USB3 device is recognised as a USB3 device
>> rather than enumberating as a USB2 device).
> After my 20 second look at the 2 patches of this set you sent me, I've
> concluded that it looks barking mad.  In patch 2 you're adding the
> XUSB MFD driver, then in this patch you're telling us that you're
> moving away from MFD despite adding more code to the subsystem.

Hi Lee,

Sorry, seems git send-email added you of it's own volition.

I've sent these patches to the mailing list for comment/help not for 
submission. As mentioned in the cover email, the first 5 patches are 
from an existing series that has been rejected. The later 3 patches show 
my modifications. I have not yet moved these files from the MFD 
directory, but will before submission (the series will be reworked so 
that the driver never goes into the MFD area).

> Besides, I'm never applying a patch that self confesses to be "hacky
> in places" into Mainline, ever.

As I mentioned before, I'm posting these patches for comment (hence why 
I've marked them as "RFC" not "PATCH").

Martyn

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/