Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753478AbbKBO1o (ORCPT ); Mon, 2 Nov 2015 09:27:44 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:38170 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751024AbbKBO1k (ORCPT ); Mon, 2 Nov 2015 09:27:40 -0500 Subject: Re: [PATCH RESEND 14/16] hwmon: add TI LMU hardware fault monitoring driver To: Milo Kim , devicetree@vger.kernel.org, lee.jones@linaro.org, linux-kernel@vger.kernel.org References: <1446441875-1256-1-git-send-email-milo.kim@ti.com> <1446441875-1256-15-git-send-email-milo.kim@ti.com> Cc: Jean Delvare , lm-sensors@lm-sensors.org From: Guenter Roeck Message-ID: <563772D7.4030807@roeck-us.net> Date: Mon, 2 Nov 2015 06:27:35 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1446441875-1256-15-git-send-email-milo.kim@ti.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1007 Lines: 24 On 11/01/2015 09:24 PM, Milo Kim wrote: > LM3633 and LM3697 are TI LMU MFD device. > Those device have hardware monitoring feature which detects opened or > shorted circuit case. > Sure, but it only makes sense if you provide standard hwmon attributes which can be interpreted by the "sensors" command. Which is not the case here. You neither have a standard device type (light is not handled by hwmon), nor standard attributes, nor do the attributes return standard values. I think there may be a basic misunderstanding. hwmon is not intended to monitor a specific chip on the board. Its scope is to monitor the system (such as temperature, voltages, or current). In your case, it might be better to attach the attributes to the mfd device. Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/