Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753537AbbKBO3m (ORCPT <rfc822;w@1wt.eu>);
	Mon, 2 Nov 2015 09:29:42 -0500
Received: from bh-25.webhostbox.net ([208.91.199.152]:38345 "EHLO
	bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751819AbbKBO3i (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 2 Nov 2015 09:29:38 -0500
Subject: Re: [PATCH -next] serial: etraxfs-uart: Fix crash
To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <u.kleine-koenig@pengutronix.de>
References: <1446431576-4385-1-git-send-email-linux@roeck-us.net>
 <20151102073755.GN4931@pengutronix.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jslaby@suse.com>, linux-serial@vger.kernel.org,
        linux-kernel@vger.kernel.org, Niklas Cassel <nks@flawful.org>
From: Guenter Roeck <linux@roeck-us.net>
Message-ID: <56377350.7040005@roeck-us.net>
Date: Mon, 2 Nov 2015 06:29:36 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <20151102073755.GN4931@pengutronix.de>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 8bit
X-Authenticated_sender: linux@roeck-us.net
X-OutGoing-Spam-Status: No, score=-1.0
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net
X-AntiAbuse: Original Domain - vger.kernel.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - roeck-us.net
X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net
X-Source: 
X-Source-Args: 
X-Source-Dir: 
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1783
Lines: 47

On 11/01/2015 11:37 PM, Uwe Kleine-K?nig wrote:
> Hello,
>
> On Sun, Nov 01, 2015 at 06:32:56PM -0800, Guenter Roeck wrote:
>> Since commit 7d8c70d8048c ("serial: mctrl-gpio: rename init function"),
>> crisv32 either do not build or crash as follows.
>>
>> Unable to handle kernel NULL pointer dereference
>> Linux 4.3.0-rc7-next-20151101 #1 Sun Nov 1 11:41:28 PST 2015
>> ...
>> Call Trace: [<c0004a0e>] show_stack+0x0/0x9e
>> [<c004c0c0>] printk+0x0/0x2c
>> [<c00059d4>] show_registers+0x14a/0x1c2
>> [<c004c0c0>] printk+0x0/0x2c
>> [<c0004b52>] die_if_kernel+0x7c/0x9e
>> [<c0005346>] do_page_fault+0x32e/0x3e6
>> [<c01dc59c>] of_get_property+0x0/0x2c
>> [<c01e0558>] of_irq_parse_raw+0x12a/0x376
>> [<c01dc59c>] of_get_property+0x0/0x2c
>> [<c0053aca>] get_page_from_freelist+0x73e/0x856
>> [<c01dc59c>] of_get_property+0x0/0x2c
>> [<c0008912>] d_mmu_refill+0x10a/0x112
>> [<c01b488c>] devm_kmalloc+0x40/0x56
>> [<c01b47d0>] add_dr+0xc/0x1c
>> [<c01b4800>] devm_add_action+0x2/0x4e
>> [<c01abdbc>] mctrl_gpio_init_noauto+0x1c/0x76
>> [<c01abf9e>] mctrl_gpio_init+0x22/0x110
>
> There should be a warning at compile time about mismatching parameters.
>
>> The function call in the etraxfs-uart driver was not renamed,
>> possibly due to interference with commit 7b9c5162c182 ("serial:
>> etraxfs-uart: use mctrl_gpio helpers for handling modem signals").
>
> Yes. BTW, 7b9c5162c182 looks broken, too, because the interrupt handling
> is missing.
>

I can not comment on that; all I can say is that it works for me with qemu.

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/