MIME-Version: 1.0
In-Reply-To: <1446258260-72902-2-git-send-email-zhongkaihua@huawei.com>
References: <1446258260-72902-1-git-send-email-zhongkaihua@huawei.com> <1446258260-72902-2-git-send-email-zhongkaihua@huawei.com>
From: Rob Herring <robh+dt@kernel.org>
Date: Mon, 2 Nov 2015 09:09:33 -0600
Message-ID: <CAL_JsqK1HJ1aDRWMj+7SVXz_zBbD_qbBZ79cbWCnLeKT2++bbw@mail.gmail.com>
Subject: Re: [PATCH 2/3] dt-bindings: gpio: Documentation for Hi6220 gpio driver
To: Zhong Kaihua <zhongkaihua@huawei.com>
Cc: Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>, Yiping Xu <xuyiping@hisilicon.com>,
        Wei Xu <xuwei5@hisilicon.com>, Bintian Wang <bintian.wang@huawei.com>,
        Haojian Zhuang <haojian.zhuang@linaro.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Chen Feng <puck.chen@hisilicon.com>, w.f@huawei.com,
        dan.zhao@hisilicon.com, Xinwei Kong <kong.kongxinwei@hisilicon.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2119
Lines: 55

On Fri, Oct 30, 2015 at 9:24 PM, Zhong Kaihua <zhongkaihua@huawei.com> wrote:
> dt-bindings: gpio: Documentation for Hi6220 gpio driver
>
> Signed-off-by: Zhong Kaihua <zhongkaihua@huawei.com>
> ---
>  .../devicetree/bindings/gpio/gpio-hi6220.txt       | 23 ++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/gpio/gpio-hi6220.txt
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt b/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt
> new file mode 100644
> index 0000000..76a8932
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt
> @@ -0,0 +1,23 @@
> +Hisilicon Hi6220 GPIO controller bindings
> +
> +Required properties:
> +  - compatible:        "arm,pl061", "arm,primecell"
> +  - gpio-controller: Marks the device node as a        GPIO controller.
> +  - #gpio-cells: Should        be 2. See gpio.txt in this directory for a

Some strange spacing in here. Otherwise,

Acked-by: Rob Herring <robh@kernel.org>

> +                description of the cells format.
> +  - interrupt-controller: Mark the device node as an interrupt controller
> +
> +Example:
> +
> +       gpio0: gpio@f8011000 {
> +               compatible = "arm,pl061", "arm,primecell";
> +               reg = <0x0 0xf8011000 0x0 0x1000>;
> +               interrupts = <0 52 0x4>;
> +               gpio-controller;
> +               #gpio-cells = <2>;
> +               interrupt-controller;
> +               #interrupt-cells = <2>;
> +               clocks = <&ao_ctrl 2>;
> +               clock-names = "apb_pclk";
> +               status = "ok";
> +       };
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/