Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754114AbbKBPui (ORCPT ); Mon, 2 Nov 2015 10:50:38 -0500 Received: from mx2.suse.de ([195.135.220.15]:42204 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752066AbbKBPug (ORCPT ); Mon, 2 Nov 2015 10:50:36 -0500 Date: Mon, 2 Nov 2015 16:50:33 +0100 From: Michal Marek To: Thiago Macieira Cc: Alexey Brodkin , "linux-kernel@vger.kernel.org" Subject: Re: make xconfig no longer works in Fedora Message-ID: <20151102155033.GA15852@sepie.suse.cz> References: <1446295161.4394.81.camel@synopsys.com> <1540852.ryHORPH4E7@tjmaciei-mobl4> <56373CBB.3010801@suse.com> <2978371.kMj1QX9251@tjmaciei-mobl4> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2978371.kMj1QX9251@tjmaciei-mobl4> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1146 Lines: 25 On Mon, Nov 02, 2015 at 08:46:55AM -0500, Thiago Macieira wrote: > On Monday 02 November 2015 11:36:43 Michal Marek wrote: > > On 2015-11-02 04:20, Thiago Macieira wrote: > > > - qtver=`qmake -query QT_VERSION` || { \ > > > + qtver=`qmake -query QT_VERSION` || \ > > > + qtver=`qmake-qt5 -query QT_VERSION` || \ > > > + qtver=`qmake-qt4 -query QT_VERSION` || { \ > > > > The qtlibdir= etc assignments below still use qmake directly, plus this > > will print an error if the command is not called "qmake." As Alexey > > says, we do not need qmake, we need moc and the cflags / ldflags. Since > > pkg-config worked for us previously, I suggest to use pkg-config again > > and just check which of QtGui or Qt5Widgets is available. > > Here's an attempt using pkg-config. Works for me on openSUSE, it just started to prefer Qt5 now. But it correctly builds against Qt4 if Qt5 is not available. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/