Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754164AbbKBQB7 (ORCPT ); Mon, 2 Nov 2015 11:01:59 -0500 Received: from mga03.intel.com ([134.134.136.65]:5377 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754105AbbKBQBz (ORCPT ); Mon, 2 Nov 2015 11:01:55 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,234,1444719600"; d="scan'208";a="592594607" From: Thiago Macieira To: Michal Marek Cc: Alexey Brodkin , "linux-kernel@vger.kernel.org" Subject: Re: make xconfig no longer works in Fedora Date: Mon, 02 Nov 2015 11:01:44 -0500 Message-ID: <25378935.a1olKg0W2g@tjmaciei-mobl4> Organization: Intel Corporation User-Agent: KMail/4.14.10 (Linux/4.2.1-1-desktop; KDE/4.14.12; x86_64; ; ) In-Reply-To: <20151102155033.GA15852@sepie.suse.cz> References: <1446295161.4394.81.camel@synopsys.com> <2978371.kMj1QX9251@tjmaciei-mobl4> <20151102155033.GA15852@sepie.suse.cz> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1799 Lines: 38 On Monday 02 November 2015 16:50:33 Michal Marek wrote: > On Mon, Nov 02, 2015 at 08:46:55AM -0500, Thiago Macieira wrote: > > On Monday 02 November 2015 11:36:43 Michal Marek wrote: > > > On 2015-11-02 04:20, Thiago Macieira wrote: > > > > - qtver=`qmake -query QT_VERSION` || { \ > > > > + qtver=`qmake -query QT_VERSION` || \ > > > > + qtver=`qmake-qt5 -query QT_VERSION` || \ > > > > + qtver=`qmake-qt4 -query QT_VERSION` || { \ > > > > > > The qtlibdir= etc assignments below still use qmake directly, plus this > > > will print an error if the command is not called "qmake." As Alexey > > > says, we do not need qmake, we need moc and the cflags / ldflags. Since > > > pkg-config worked for us previously, I suggest to use pkg-config again > > > and just check which of QtGui or Qt5Widgets is available. > > > > Here's an attempt using pkg-config. > > Works for me on openSUSE, it just started to prefer Qt5 now. But it > correctly builds against Qt4 if Qt5 is not available. That's a consequence of using pkg-config. Now you can no longer choose your preferred Qt version by setting QT_SELECT, like the qmake solution would have allowed, as recommended by the Qt Project. At least, the qtchooser shell function extension does set PKG_CONFIG_PATH, so if you install a different version elsewhere, that version should be picked up. It would have been the same with CMake too, btw. Alexey, did this solve the problem for you? -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/