Subject: Re: make xconfig no longer works in Fedora
To: Thiago Macieira <thiago.macieira@intel.com>
References: <1446295161.4394.81.camel@synopsys.com>
 <2978371.kMj1QX9251@tjmaciei-mobl4> <20151102155033.GA15852@sepie.suse.cz>
 <25378935.a1olKg0W2g@tjmaciei-mobl4>
Cc: Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
From: Michal Marek <mmarek@suse.com>
Message-ID: <56378A2A.8070803@suse.com>
Date: Mon, 2 Nov 2015 17:07:06 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <25378935.a1olKg0W2g@tjmaciei-mobl4>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1636
Lines: 35

On 2015-11-02 17:01, Thiago Macieira wrote:
> On Monday 02 November 2015 16:50:33 Michal Marek wrote:
>> On Mon, Nov 02, 2015 at 08:46:55AM -0500, Thiago Macieira wrote:
>>> On Monday 02 November 2015 11:36:43 Michal Marek wrote:
>>>> On 2015-11-02 04:20, Thiago Macieira wrote:
>>>>> -	qtver=`qmake -query QT_VERSION` || { \
>>>>> +	qtver=`qmake -query QT_VERSION` || \
>>>>> +	qtver=`qmake-qt5 -query QT_VERSION` || \
>>>>> +	qtver=`qmake-qt4 -query QT_VERSION` || { \
>>>>
>>>> The qtlibdir= etc assignments below still use qmake directly, plus this
>>>> will print an error if the command is not called "qmake." As Alexey
>>>> says, we do not need qmake, we need moc and the cflags / ldflags. Since
>>>> pkg-config worked for us previously, I suggest to use pkg-config again
>>>> and just check which of QtGui or Qt5Widgets is available.
>>>
>>> Here's an attempt using pkg-config.
>>
>> Works for me on openSUSE, it just started to prefer Qt5 now. But it
>> correctly builds against Qt4 if Qt5 is not available.
> 
> That's a consequence of using pkg-config. Now you can no longer choose your 
> preferred Qt version by setting QT_SELECT, like the qmake solution would have 
> allowed, as recommended by the Qt Project.

Yeah, but I think this is acceptable for an application like qconf. Use
best effort to build against some Qt version to let the user configure
their kernel.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/