Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754168AbbKBQK1 (ORCPT ); Mon, 2 Nov 2015 11:10:27 -0500 Received: from resqmta-ch2-02v.sys.comcast.net ([69.252.207.34]:56300 "EHLO resqmta-ch2-02v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753406AbbKBQKY (ORCPT ); Mon, 2 Nov 2015 11:10:24 -0500 Date: Mon, 2 Nov 2015 10:10:23 -0600 (CST) From: Christoph Lameter X-X-Sender: cl@east.gentwo.org To: Jungseok Lee cc: catalin.marinas@arm.com, will.deacon@arm.com, tj@kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, james.morse@arm.com, takahiro.akashi@linaro.org, mark.rutland@arm.com, barami97@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 2/3] percpu: add PERCPU_ATOM_SIZE for a generic percpu area setup In-Reply-To: <1446363977-23656-3-git-send-email-jungseoklee85@gmail.com> Message-ID: References: <1446363977-23656-1-git-send-email-jungseoklee85@gmail.com> <1446363977-23656-3-git-send-email-jungseoklee85@gmail.com> Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 827 Lines: 17 On Sun, 1 Nov 2015, Jungseok Lee wrote: > There is no room to adjust 'atom_size' now when a generic percpu area > is used. It would be redundant to write down an architecture-specific > setup_per_cpu_areas() in order to only change the 'atom_size'. Thus, > this patch adds a new definition, PERCPU_ATOM_SIZE, which is PAGE_SIZE > by default. The value could be updated if needed by architecture. What is atom_size? Why would you want a difference allocation size here? The percpu area is virtually mapped regardless. So you will have contiguous addresses even without atom_size. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/