Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753988AbbKBQy3 (ORCPT ); Mon, 2 Nov 2015 11:54:29 -0500 Received: from mxf4.bahnhof.se ([213.80.101.28]:56261 "EHLO mxf4.bahnhof.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752603AbbKBQy1 (ORCPT ); Mon, 2 Nov 2015 11:54:27 -0500 X-Greylist: delayed 1797 seconds by postgrey-1.27 at vger.kernel.org; Mon, 02 Nov 2015 11:54:26 EST X-Spam-Score: 0 Subject: Re: [PATCH -next] serial: etraxfs-uart: Fix crash To: Guenter Roeck , Greg Kroah-Hartman References: <1446431576-4385-1-git-send-email-linux@roeck-us.net> Cc: Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= From: Niklas Cassel Message-ID: <56378E35.6050102@flawful.org> Date: Mon, 2 Nov 2015 17:24:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1446431576-4385-1-git-send-email-linux@roeck-us.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2394 Lines: 60 Acked-by: Niklas Cassel On 11/02/2015 03:32 AM, Guenter Roeck wrote: > Since commit 7d8c70d8048c ("serial: mctrl-gpio: rename init function"), > crisv32 either do not build or crash as follows. > > Unable to handle kernel NULL pointer dereference > Linux 4.3.0-rc7-next-20151101 #1 Sun Nov 1 11:41:28 PST 2015 > ... > Call Trace: [] show_stack+0x0/0x9e > [] printk+0x0/0x2c > [] show_registers+0x14a/0x1c2 > [] printk+0x0/0x2c > [] die_if_kernel+0x7c/0x9e > [] do_page_fault+0x32e/0x3e6 > [] of_get_property+0x0/0x2c > [] of_irq_parse_raw+0x12a/0x376 > [] of_get_property+0x0/0x2c > [] get_page_from_freelist+0x73e/0x856 > [] of_get_property+0x0/0x2c > [] d_mmu_refill+0x10a/0x112 > [] devm_kmalloc+0x40/0x56 > [] add_dr+0xc/0x1c > [] devm_add_action+0x2/0x4e > [] mctrl_gpio_init_noauto+0x1c/0x76 > [] mctrl_gpio_init+0x22/0x110 > > The function call in the etraxfs-uart driver was not renamed, > possibly due to interference with commit 7b9c5162c182 ("serial: > etraxfs-uart: use mctrl_gpio helpers for handling modem signals"). > > Fixes: 7d8c70d8048c ("serial: mctrl-gpio: rename init function") > Cc: Uwe Kleine-König > Cc: Niklas Cassel > Signed-off-by: Guenter Roeck > --- > It might make sense to merge this patch into the original patch if possible. > > drivers/tty/serial/etraxfs-uart.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/etraxfs-uart.c b/drivers/tty/serial/etraxfs-uart.c > index 6813e316e9ff..2f80bc7e44fb 100644 > --- a/drivers/tty/serial/etraxfs-uart.c > +++ b/drivers/tty/serial/etraxfs-uart.c > @@ -894,7 +894,7 @@ static int etraxfs_uart_probe(struct platform_device *pdev) > up->regi_ser = of_iomap(np, 0); > up->port.dev = &pdev->dev; > > - up->gpios = mctrl_gpio_init(&pdev->dev, 0); > + up->gpios = mctrl_gpio_init_noauto(&pdev->dev, 0); > if (IS_ERR(up->gpios)) > return PTR_ERR(up->gpios); > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/