From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: "thiago.macieira@intel.com" <thiago.macieira@intel.com>
CC: "mmarek@suse.com" <mmarek@suse.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: make xconfig no longer works in Fedora
Thread-Topic: make xconfig no longer works in Fedora
Thread-Index: AQHRE9kqYBgy+KCrJEi6vlaPU4OGbp6IAnOAgAB50oCAADUkgIAAIouAgAADIACAAAd5gA==
Date: Mon, 2 Nov 2015 16:28:29 +0000
Message-ID: <1446481709.14169.18.camel@synopsys.com>
References: <1446295161.4394.81.camel@synopsys.com>
	 <2978371.kMj1QX9251@tjmaciei-mobl4> <20151102155033.GA15852@sepie.suse.cz>
	 <25378935.a1olKg0W2g@tjmaciei-mobl4>
In-Reply-To: <25378935.a1olKg0W2g@tjmaciei-mobl4>
Accept-Language: en-US, ru-RU
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
Content-ID: <3F357C8576A8814EB83CDE3636313BEE@internal.synopsys.com>
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 1790
Lines: 37

Hi Thiago,

On Mon, 2015-11-02 at 11:01 -0500, Thiago Macieira wrote:
> On Monday 02 November 2015 16:50:33 Michal Marek wrote:
> > On Mon, Nov 02, 2015 at 08:46:55AM -0500, Thiago Macieira wrote:
> > > On Monday 02 November 2015 11:36:43 Michal Marek wrote:
> > > > On 2015-11-02 04:20, Thiago Macieira wrote:
> > > > > -	qtver=`qmake -query QT_VERSION` || { \
> > > > > +	qtver=`qmake -query QT_VERSION` || \
> > > > > +	qtver=`qmake-qt5 -query QT_VERSION` || \
> > > > > +	qtver=`qmake-qt4 -query QT_VERSION` || { \
> > > > 
> > > > The qtlibdir= etc assignments below still use qmake directly, plus this
> > > > will print an error if the command is not called "qmake." As Alexey
> > > > says, we do not need qmake, we need moc and the cflags / ldflags. Since
> > > > pkg-config worked for us previously, I suggest to use pkg-config again
> > > > and just check which of QtGui or Qt5Widgets is available.
> > > 
> > > Here's an attempt using pkg-config.
> > 
> > Works for me on openSUSE, it just started to prefer Qt5 now. But it
> > correctly builds against Qt4 if Qt5 is not available.
> 
> That's a consequence of using pkg-config. Now you can no longer choose your 
> preferred Qt version by setting QT_SELECT, like the qmake solution would have 
> allowed, as recommended by the Qt Project. At least, the qtchooser shell 
> function extension does set PKG_CONFIG_PATH, so if you  install a different 
> version elsewhere, that version should be picked up.
> 
> It would have been the same with CMake too, btw.
> 
> Alexey, did this solve the problem for you?

Yep, thanks a lot.
"make xconfig" now works for me!

-Alexey????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?