Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752640AbbKBUKd (ORCPT ); Mon, 2 Nov 2015 15:10:33 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:2767 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751280AbbKBUKb (ORCPT ); Mon, 2 Nov 2015 15:10:31 -0500 Date: Mon, 2 Nov 2015 15:10:22 -0500 From: Dave Jones To: Linus Torvalds CC: Linux Kernel , Andrew Morton , Shaohua Li Subject: Re: mm: remove vmalloc info from /proc/meminfo Message-ID: <20151102201021.GA14806@fb.com> Mail-Followup-To: Dave Jones , Linus Torvalds , Linux Kernel , Andrew Morton , Shaohua Li References: <20151102183629.GA10347@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [192.168.52.123] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-11-02_12:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1614 Lines: 34 On Mon, Nov 02, 2015 at 11:29:15AM -0800, Linus Torvalds wrote: > On Mon, Nov 2, 2015 at 10:36 AM, Dave Jones wrote: > > Reading /proc/meminfo is really slow, as it requires recomputing the > > vmalloc data every time, which is a lot of work, when most (all?) > > consumers of meminfo don't even care about those statistics. > > Ahh. My version of this patch (which I actually committed yesterday, > since I remembered - will wonders never cease?) leaves the fields > around in the /proc/meminfo file, but just makes the values be zero. > It also removes the actual function to compute the data that nobody > uses any more. > > I agree that we can eventually look at even removing the fields > entirely, but that's much more likely to break things. I can imagine > system tools that just root around for values, and break and complain > when they don't exist, even if all they do is report them (rather than > actually *use* them for anythign). > > I guess I should just push out my tree. I didn't want to keep people > from testing plain 4.3, so I didn't push out yesterday. > > Can you test what is now (where "now" means "it might take a minute or > two to mirror out") in my git repo? That looks like it'll do the job just as well yeah, and I suppose is a touch more conservative than my "burn it all down" approach. Dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/