Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753520AbbKBUuS (ORCPT ); Mon, 2 Nov 2015 15:50:18 -0500 Received: from fieldses.org ([173.255.197.46]:41132 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752773AbbKBUuN (ORCPT ); Mon, 2 Nov 2015 15:50:13 -0500 Date: Mon, 2 Nov 2015 15:50:12 -0500 To: Neil Brown Cc: Chris Mason , Al Viro , Christoph Hellwig , Linux btrfs Developers List , Linux FS-devel Mailing List , LKML Subject: Re: [PATCH/RFC] make btrfs subvol mounts appear in /proc/mounts Message-ID: <20151102205012.GA26986@fieldses.org> References: <87oafkc5kp.fsf@notabene.neil.brown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87oafkc5kp.fsf@notabene.neil.brown.name> User-Agent: Mutt/1.5.21 (2010-09-15) From: bfields@fieldses.org (J. Bruce Fields) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1481 Lines: 32 On Wed, Oct 28, 2015 at 07:25:10AM +0900, Neil Brown wrote: > > If you create a subvolume in btrfs and access it (by name) without > mounting it, then the subvolume looks like a separate mount to some > extent, returning a different st_dev to stat(), but it doesn't look like > a separate mount in that it isn't listed in /proc/mounts. This > inconsistency can confuse tools. > > This patch causes these subvolumes to become separate mounts by using > the VFS' automount functionality, much like NFS uses automount when it > discovered mountpoints on the server. > > The VFS currently makes it impossible to auto-mount a directory on to itself > (i.e. a bind mount). For NFS this isn't a problem as a new superblock > is created for the child filesystem so there are two separate dentries > (and inodes) for the one directory: one in the parent filesystem, one in > the child (note that the two superblocks share a common connection to > the server so there is still a lot of commonality). > > BTRFS has chosen instead to use a single superblock for all subvolumes. Naive question: was there a reason for that choice? --b. > This results in a single dentry for the subvol-root. A dentry which > must be auto-mounted on itself. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/