Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753743AbbKBVAG (ORCPT ); Mon, 2 Nov 2015 16:00:06 -0500 Received: from mail-pa0-f46.google.com ([209.85.220.46]:34455 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753648AbbKBVAE (ORCPT ); Mon, 2 Nov 2015 16:00:04 -0500 Date: Mon, 2 Nov 2015 13:00:01 -0800 From: Brian Norris To: Boris Brezillon Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Ezequiel Garcia , Marek Vasut , Scott Wood , Josh Wu , Robert Jarzmik , Kyungmin Park , Han Xu Subject: Re: [PATCH v2 06/11] mtd: nand: drop unnecessary partition parser data Message-ID: <20151102210001.GB7274@google.com> References: <1446262410-45754-1-git-send-email-computersforpeace@gmail.com> <1446262410-45754-7-git-send-email-computersforpeace@gmail.com> <20151101233237.21155d9e@bbrezillon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151101233237.21155d9e@bbrezillon> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1320 Lines: 31 On Sun, Nov 01, 2015 at 11:32:37PM +0100, Boris Brezillon wrote: > On Fri, 30 Oct 2015 20:33:25 -0700 > Brian Norris wrote: > [...] > > diff --git a/drivers/mtd/nand/fsl_elbc_nand.c b/drivers/mtd/nand/fsl_elbc_nand.c > > index dcb1f7f4873f..850546dc98c8 100644 > > --- a/drivers/mtd/nand/fsl_elbc_nand.c > > +++ b/drivers/mtd/nand/fsl_elbc_nand.c > > @@ -748,6 +748,7 @@ static int fsl_elbc_chip_init(struct fsl_elbc_mtd *priv) > > /* Fill in fsl_elbc_mtd structure */ > > priv->mtd.priv = chip; > > priv->mtd.dev.parent = priv->dev; > > + chip->flash_node = priv->dev->of_node; > > Shouldn't we use the nand_set_flash_node() helper here? Here is a diff replacing > all 'chip->flash_node =' occurrences by nand_set_flash_node(): Hmm, I don't know why I overlooked those. I think maybe I did the initial replacement before this patch and forgot to do the same replacement on my subsequent work. I guess that's what happens when I rebase/rework too much... Thanks for the diff. I'll probably squash it into v3 if/when that comes. Brian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/