Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753930AbbKBVOG (ORCPT ); Mon, 2 Nov 2015 16:14:06 -0500 Received: from mxf4.bahnhof.se ([213.80.101.28]:54457 "EHLO mxf4.bahnhof.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751275AbbKBVOC (ORCPT ); Mon, 2 Nov 2015 16:14:02 -0500 X-Spam-Score: 0 Subject: Re: [PATCH -next] serial: etraxfs-uart: Fix crash To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Guenter Roeck References: <1446431576-4385-1-git-send-email-linux@roeck-us.net> <20151102073755.GN4931@pengutronix.de> Cc: Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org From: Niklas Cassel Message-ID: <5637D1F5.2090608@flawful.org> Date: Mon, 2 Nov 2015 22:13:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151102073755.GN4931@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1372 Lines: 31 On 11/02/2015 08:37 AM, Uwe Kleine-König wrote: >> The function call in the etraxfs-uart driver was not renamed, >> possibly due to interference with commit 7b9c5162c182 ("serial: >> etraxfs-uart: use mctrl_gpio helpers for handling modem signals"). > Yes. BTW, 7b9c5162c182 looks broken, too, because the interrupt handling > is missing. The only drivers including serial_mctrl_gpio.h is atmel_serial.c, clps711x.c, mxs-auart.c and etraxfs-uart.c etraxfs commit 7b9c5162c182 ("serial: etraxfs-uart: use mctrl_gpio helpers for handling modem signals") is heavily influenced by 62b0a1b3e759 ("serial: clps711x: Use mctrl_gpio helpers for handling modem signals") a driver which also appears to lack mctrl irq setup/handling. Uwe, are you going to convert all serial drivers that includes serial_mctrl_gpio.h to use the new mctrl_gpio_init? (which also sets up irqs) Since mctrl gpios are optional in the device tree, I guess mctrl_gpio_init handles if they are missing. So even if etraxfs-uart.c currently lacks mctrl irq setup/handling, if we migrate it to use the new mctrl_gpio_init, we will get this automatically? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/