Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754195AbbKBVoC (ORCPT ); Mon, 2 Nov 2015 16:44:02 -0500 Received: from lists.s-osg.org ([54.187.51.154]:55260 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752771AbbKBVn7 (ORCPT ); Mon, 2 Nov 2015 16:43:59 -0500 Subject: Re: [PATCH] selftests/seccomp: Be more precise with syscall arguments. To: Robert Sesek References: <1446490222-528-1-git-send-email-rsesek@google.com> <5637C30F.70001@osg.samsung.com> Cc: Kees Cook , LKML , Shuah Khan From: Shuah Khan Organization: Samsung Open Source Group Message-ID: <5637D91D.1000001@osg.samsung.com> Date: Mon, 2 Nov 2015 14:43:57 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1539 Lines: 48 On 11/02/2015 01:32 PM, Robert Sesek wrote: > On Mon, Nov 2, 2015 at 3:09 PM, Shuah Khan wrote: >> On 11/02/2015 12:49 PM, Kees Cook wrote: >>> On Mon, Nov 2, 2015 at 10:50 AM, Robert Sesek wrote: >>>> Certain syscall emulation layers strictly check that the number of >>>> arguments match what the syscall handler expects. The KILL_one_arg_one and >>>> KILL_one_arg_six tests passed more parameters than expected to various >>>> syscalls, causing failures in this emulation mode. Instead, test using >>>> syscalls that take the appropriate number of arguments. >>>> >>>> Signed-off-by: Robert Sesek >>> >>> Signed-off-by: Kees Cook >>> >>> Looks great, thanks! >>> >>> Shuah, can you take this into the selftests tree? >>> >> >> Robert, >> >> Could you please send this patch to me. It didn't make to >> my Inbox. >> >> thanks, >> -- Shuah > > Sure. I have re-mailed you the patch directly. It's also available here: > https://patchwork.kernel.org/patch/7537891/ > Applied to linux-kselftest next for 4.4 with Kees's signedoff Thanks -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/