Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753971AbbKBWOZ (ORCPT ); Mon, 2 Nov 2015 17:14:25 -0500 Received: from us-mx2.synaptics.com ([192.147.44.131]:58232 "EHLO us-mx1.synaptics.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752716AbbKBWOU (ORCPT ); Mon, 2 Nov 2015 17:14:20 -0500 X-PGP-Universal: processed; by securemail.synaptics.com on Mon, 02 Nov 2015 15:14:23 -0800 Subject: Re: [PATCH 00/11] Input: synaptics-rmi4: various fixes for the existing rmi4 branch To: Linus Walleij , Benjamin Tissoires References: <1435087050-11444-1-git-send-email-benjamin.tissoires@redhat.com> <20150723171041.GA14941@mail.corp.redhat.com> CC: Dmitry Torokhov , Christopher Heiny , Stephen Chandler Paul , Linux Input , "linux-kernel@vger.kernel.org" From: Andrew Duggan Message-ID: <5637E03B.5010804@synaptics.com> Date: Mon, 2 Nov 2015 14:14:19 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.4.10.145] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2344 Lines: 49 On 10/31/2015 01:41 PM, Linus Walleij wrote: > On Thu, Jul 23, 2015 at 7:10 PM, Benjamin Tissoires > wrote: > >> Dmitry, the Sony guys are currently working on upstreaming their work. >> Their Xperia are using a Synaptics I2C touchscreen. They are able to >> boot with an upstream kernel a lot of parts now, and they will >> eventually need the upstream touch controller. > I have a Synaptics touchscreen thing since 2010 waiting in > drivers/staging/ste_rmi4. > > Is there *anything* I can do to help further this? > > It just seems like a massive body of code that doesn't get the > right love, Benjamin have you considered just merging this into > drivers/staging so it is simple for everyone to participate, or are there > infrastructural blockers? > > Yours, > Linus Walleij I have been continuing to work on the synaptics-rmi4 driver and was just trying to figure out what the next step should be. I recently uploaded my changes here https://github.com/aduggan/linux. I've held off on posting more patches to the list since there are previous patches still outstanding and I didn't want to inundate the list. But, at this point I think I would appreciate someone volunteering to review it. I can post some or all of it to the list if that's the best place for that to happen. I've added support for newer devices (Function 12), connected it up to hid-rmi to support HID touchpads, and reworked the SPI transport driver. I'm able to get basic support for touch working for a variety of devices RMI4 over I2C on a Nexus 4, RMI4 over SPI on a Nexus 9, and RMI4 over HID on various touchpads. With Benjamin's SMBus work it won't take much to also support SMBus touchpads. I think the biggest blocker right now is just the fact that it is a large body of code and there hasn't been enough continuous activity to on it. So whenever a new patch is posted, reviewers have to go through the time consuming process of relearning the code. But, there are a lot of RMI4 devices out there without an upstreamed driver so I think it is worth doing. Andrew -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/