MIME-Version: 1.0
In-Reply-To: <20151022140307.GG32514@kernel.org>
References: <1445495330-25416-1-git-send-email-namhyung@kernel.org>
 <1445495330-25416-3-git-send-email-namhyung@kernel.org> <20151022073247.GA14234@gmail.com>
 <CAM9d7ciVuSBUdJGs8c5nMwHCJ2fXO0vuoLujO0-HhxQN7e-4ww@mail.gmail.com>
 <CAE40pdfbyCsN90q+WG5R46AS_6OkYFAx9CAam1-AXOhoCMbCLQ@mail.gmail.com> <20151022140307.GG32514@kernel.org>
From: Brendan Gregg <brendan.d.gregg@gmail.com>
Date: Mon, 2 Nov 2015 15:59:49 -0800
Message-ID: <CAE40pdeNv88+KwWLpztjOvNsmy9UoE0c=QjTVmHrB+RRCsutHw@mail.gmail.com>
Subject: Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order
 only if --children is enabled
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>, Jiri Olsa <jolsa@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>,
        Adrian Hunter <adrian.hunter@intel.com>, Borislav Petkov <bp@suse.de>,
        Chandler Carruth <chandlerc@gmail.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Stephane Eranian <eranian@google.com>, Wang Nan <wangnan0@huawei.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1157
Lines: 30

On Thu, Oct 22, 2015 at 7:03 AM, Arnaldo Carvalho de Melo
<arnaldo.melo@gmail.com> wrote:
> Em Thu, Oct 22, 2015 at 02:49:11AM -0700, Brendan Gregg escreveu:
>> On Thu, Oct 22, 2015 at 12:38 AM, Namhyung Kim <namhyung@kernel.org> wrote:
>> > Hi Ingo,
>> >
>> > On Thu, Oct 22, 2015 at 4:32 PM, Ingo Molnar <mingo@kernel.org> wrote:
>> >>
>> >> * Namhyung Kim <namhyung@kernel.org> wrote:
>> >>
>> >>> The caller callchain order is useful with --children option since it can
>> >>> show 'overview' style output, but other commands which don't use
>> >>>  --children feature like 'perf script' or even 'perf report/top' without
>> >>>  --children are better to keep caller order.
>> >
>> > Oops, there's a typo:  s/caller order/callee order/ :)
>>
>> Thanks, I was wondering about that (and I've made that typo myself).
>> Thanks for the patch!
>
> Brendan, can I take that as an Acked-by?

Belated, yes!

Brendan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/